chore(backend): remove dead Dockerfile.mentorship-sync#195
Open
mlehotskylf wants to merge 2 commits into
Open
Conversation
The mentorship-sync binary is built into the main backend Dockerfile alongside initiatives-api and ledger-stats-sync (commit 3864eed), and the CronJob Helm template uses that image. Dockerfile.mentorship-sync is no longer referenced by any build and is dead. Also correct the architecture decision doc: it described a never-implemented per-entrypoint Dockerfile design. Document the actual single-image layout (all binaries in backend/Dockerfile, selected via container command), matching how ledger-stats-sync already works. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Michal Lehotsky <mlehotsky@linuxfoundation.org>
mlehotskylf
requested review from
dealako,
emlimlf and
lewisojile
as code owners
June 22, 2026 17:55
Contributor
There was a problem hiding this comment.
Pull request overview
Cleans up the backend build/docs by removing an obsolete mentorship-sync Dockerfile and updating the backend rewrite decisions doc to reflect the current “single image, multiple binaries” deployment approach (CronJobs selecting the intended binary via command).
Changes:
- Delete
backend/Dockerfile.mentorship-syncas it’s no longer used for builds. - Update
backend/docs/rewrite/02-decisions.mdto document the single-image layout and binary selection pattern.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| backend/docs/rewrite/02-decisions.md | Updates the architecture decision record to describe bundling multiple Go binaries into backend/Dockerfile and selecting entrypoints via K8s command. |
| backend/Dockerfile.mentorship-sync | Removes an unused, now-superseded Dockerfile for a separate mentorship-sync image. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lewisojile
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backend/Dockerfile.mentorship-sync— it's no longer referenced by any build. Thementorship-syncbinary is built into the mainbackend/Dockerfilealongsideinitiatives-apiandledger-stats-sync(commit 3864eed), and the CronJob runs from that image.backend/docs/rewrite/02-decisions.md, which described a per-entrypoint Dockerfile design that was never implemented. Documents the actual single-image layout (all binaries inbackend/Dockerfile, each K8s resource selecting its binary viacommand), matching howledger-stats-syncalready works.Context
Prod mentorship-sync is verified working from the backend image. This is cleanup of the now-superseded separate-image approach (closed #178 and linuxfoundation/lfx-v2-argocd#1001).
🤖 Generated with Claude Code