Mint-X: Add support for cinnamon 6.4 #487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Check the network password dialog. The visibility icon and the hint text in the entry are light on light. |
Contributor
Author
|
Pretty sure that's fixed it but I can't test the network password dialog atm. It's fixed for keyring dialog and root auth dialog (open folder as root) so it should be the same. |
Contributor
Author
|
Tested network password dialog. Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for cinnamon 6.4. Some things could probably use some tweaking: spacing, padding etc. but it all looks reasonable enough for now.
I haven't implemented the dialog button destructive_action pseudo class (which I guess is optional anyway)and some old class names and perhaps unnecessary duplication could be removed.I couldn't test the Audio device selection dialog or network Auth dialog but they should look the same as the other dialogs.Edit: Audio device selection dialog support added and tested. NetworkSecretDialog tested and ok.
Edit: Added dialog-button:destructive-action as red text. Changing button background color would mean creating a new set of button assets and the red button text looks ok anyway.