[WIP] Fix decrypt context menu not appearing for .gpg files in Nemo #554
+77
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add decrypt menu for GPG encrypted files - Added decrypt_callback function to handle decryption requests - Added is_encrypted_file function to detect encrypted files by extension (.gpg, .asc, .sig) and MIME type - Modified logic to show Decrypt menu for encrypted files instead of no menu - Extension now properly detects .gpg files and provides decrypt context menu --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: the78mole <[email protected]>
the78mole
changed the title
mtwebster
reviewed
Oct 30, 2025
Comment on lines
+163
to
+173
| /* Check file extension for .gpg and .asc files */ | ||
| name = nemo_file_info_get_name (file); | ||
| if (name != NULL) { | ||
| int len = strlen (name); | ||
| if ((len > 4 && g_ascii_strcasecmp (name + len - 4, ".gpg") == 0) || | ||
| (len > 4 && g_ascii_strcasecmp (name + len - 4, ".asc") == 0) || | ||
| (len > 4 && g_ascii_strcasecmp (name + len - 4, ".sig") == 0)) { | ||
| result = TRUE; | ||
| } | ||
| } | ||
| g_free (name); |
Member
There was a problem hiding this comment.
I don't think this is useful - those extensions are used by many files that are not encrypted also, and the function that nemo_file_info_is_mime_type() eventually resolves to - g_content_type_is_a() - already does this sort of thing for us. We should just trust it.
mtwebster
reviewed
Oct 30, 2025
| is_all_encrypted_files (GList *files) | ||
| { | ||
| while (files) { | ||
| if (!is_encrypted_file ((NemoFileInfo*)(files->data))) |
Member
There was a problem hiding this comment.
you could just call is_mime_types() here instead, and get rid of is_encrypted_file()
clefebvre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also validated it by compiling, installing and testing the Extension on my local Linux Mint installation.
Disclaimer: I used Github Copilot to "solve" the issue, but reviewed and tested the functionality manually.
You can find the PR in my fork here: the78mole#2