-
Notifications
You must be signed in to change notification settings - Fork 207
fix: improve processor handling #859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This allows external users to e.g. apply rounded edges. Without this patch, VideoTrackRenderer will expand to its available space with no way for parent widgets to know how large the video actually is
otherwise unblurred video is visible for a few frames
|
I'll try to get the tests to pass later today, but they don't seem to be related to my changes |
|
I checked that the tests run through locally, all the other breaking stuff should be unrelated to my PR. Does anyone know what's up with dart formatter? On some of my repos it keeps finding stuff to format without any other changes 🤷 |
📝 WalkthroughWalkthroughChanges enhance track processing infrastructure by introducing asynchronous processor lifecycle management, nullable track restoration in setProcessedTrack, and expanding camera capture options with focus and exposure mode parameters. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
🔇 Additional comments (6)
✏️ Tip: You can disable this entire section by setting Comment |
This PR improves handling of processors:
copyWithwhen copying camera capture optionsTrackStreamUpdatedEventon processor changes to allow widgets to update accordinglyI'm currently working on a federated plugin to add support for virtual backgrounds and blurring on web, iOS and Android. This PR contains required changes/bug fixes I found during development
Summary by CodeRabbit
New Features
Improvements
✏️ Tip: You can customize this high-level summary in your review settings.