Skip to content

Fix py-scaffold unit test#1390

Open
michaelmckinsey1 wants to merge 13 commits into
developfrom
michaelmckinsey1-patch-3
Open

Fix py-scaffold unit test#1390
michaelmckinsey1 wants to merge 13 commits into
developfrom
michaelmckinsey1-patch-3

Conversation

@michaelmckinsey1

@michaelmckinsey1 michaelmckinsey1 commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Description

@michaelmckinsey1 michaelmckinsey1 self-assigned this Jun 12, 2026
@michaelmckinsey1

Copy link
Copy Markdown
Collaborator Author

The test actually runs as expected (https://lc.llnl.gov/gitlab/benchpark/benchpark/-/jobs/3819673). The issue is that after completion of the benchmark, there is always this error corrupted size vs. prev_size in fastbins, specifically on ROCm. We typically ignore this because it does not affect the benchmark run, however it fails the CI test because it then returns an exit code 134.

@joshuamvining Any ideas how to force this to exit code 0? The only thing I can think of is checking in .gitlab/utils/run-experiment.sh for exit code 134 and instead returning 0.

@joshuamvining

joshuamvining commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

The test actually runs as expected (https://lc.llnl.gov/gitlab/benchpark/benchpark/-/jobs/3819673). The issue is that after completion of the benchmark, there is always this error corrupted size vs. prev_size in fastbins, specifically on ROCm. We typically ignore this because it does not affect the benchmark run, however it fails the CI test because it then returns an exit code 134.

@joshuamvining Any ideas how to force this to exit code 0? The only thing I can think of is checking in .gitlab/utils/run-experiment.sh for exit code 134 and instead returning 0.

I think you could probably modify .gitlab/bin/exit-codes to have an exception for error code 134 whenever the benchmark is py-scaffold. That may be a cleaner place to put the exception than in run-experiment.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants