Add Windows release binary builds #150793
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tstellar
requested review from
boomanaiden154,
c-rhodes,
dyung,
omjavaid,
tru and
zmodem
|
I was finally able to get the script working with help from @zmodem to debug some of the issues. Right now this is x86 only. It may be possible to add aarch64, but we would need to change the build script to reduce the build time in order to fit under the 6 hour timeout. |
zmodem
left a comment
zmodem
left a comment
There was a problem hiding this comment.
Very nice!
Not an expert on the environment that this runs in, but from what I can tell, LGTM.
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
Some minor comments, broadly LGTM.
| - name: Collect Variables | ||
| id: vars | ||
| env: | ||
| LLVM_VERSION_FROM_SOURCE: ${{ format('{0}.{1}.{2}', steps.version-from-source.outputs.major, steps.version-from-source.outputs.minor, steps.version-from-source.outputs.patch) }} |
There was a problem hiding this comment.
Might be worth it in a future refactoring to make this an explicit output from the composite workflow.
| "X64" ) | ||
| tar_arch="x86_64" | ||
| ;; | ||
| "ARM64" ) |
There was a problem hiding this comment.
Is there a reason we need to explicitly handle Windows on ARM given we do not support it currently? Just making things easier in the future?
| artifact-id: ${{ steps.artifact-upload.outputs.artifact-id }} | ||
| steps: | ||
| # It's good practice to use setup-python, but this is also required on macos-14 | ||
| # due to https://github.com/actions/runner-images/issues/10385 |
There was a problem hiding this comment.
Old comment given this should be Windows specific?
| # due to https://github.com/actions/runner-images/issues/10385 | ||
| - uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0 | ||
| with: | ||
| python-version: '3.9' |
There was a problem hiding this comment.
Why python 3.9 over something newer?
4 participants
No description provided.