[TableGen] Report a better error when an InstAlias does not use a RegClass #168444
Conversation
Created using spr 1.3.8-beta.1
|
@llvm/pr-subscribers-tablegen Author: Alexander Richardson (arichardson) ChangesAlso fix the missing space in the error message. I notice while changing Full diff: https://github.com/llvm/llvm-project/pull/168444.diff 1 Files Affected:
diff --git a/llvm/utils/TableGen/Common/CodeGenInstAlias.cpp b/llvm/utils/TableGen/Common/CodeGenInstAlias.cpp
index 6c1a3e9977c28..2de27986fa04a 100644
--- a/llvm/utils/TableGen/Common/CodeGenInstAlias.cpp
+++ b/llvm/utils/TableGen/Common/CodeGenInstAlias.cpp
@@ -55,9 +55,10 @@ static Expected<ResultOperand> matchSimpleOperand(const Init *Arg,
// Match 'RegClass:$name' or 'RegOp:$name'.
if (const Record *ArgRC = T.getInitValueAsRegClassLike(Arg)) {
if (ArgRC->isSubClassOf("RegisterClass")) {
- if (!T.getRegisterClass(OpRC).hasSubClass(&T.getRegisterClass(ArgRC)))
+ if (!OpRC->isSubClassOf("RegisterClass") ||
+ !T.getRegisterClass(OpRC).hasSubClass(&T.getRegisterClass(ArgRC)))
return createStringError(
- "argument register class" + ArgRC->getName() +
+ "argument register class " + ArgRC->getName() +
" is not a subclass of operand register class " +
OpRC->getName());
if (!ArgName)
|
| @@ -55,9 +55,10 @@ static Expected<ResultOperand> matchSimpleOperand(const Init *Arg, | |||
| // Match 'RegClass:$name' or 'RegOp:$name'. | |||
| if (const Record *ArgRC = T.getInitValueAsRegClassLike(Arg)) { | |||
| if (ArgRC->isSubClassOf("RegisterClass")) { | |||
| if (!T.getRegisterClass(OpRC).hasSubClass(&T.getRegisterClass(ArgRC))) | |||
| if (!OpRC->isSubClassOf("RegisterClass") || | |||
There was a problem hiding this comment.
Maybe instead if (OpRC->isSubclassOf("RegClassByHwMode")) then report "HwMode support is not implemented"?
There was a problem hiding this comment.
Yeah that would give slightly better results but may be too restrictive. It does seem to work with HWModes as long as the RegClassByHwMode argument is the same, but it doesn't handle the subset case.
There was a problem hiding this comment.
I have some follow-up changes to improve this (printing essentially what you suggested) including a test.
🐧 Linux x64 Test Results
|
…Class Also fix the missing space in the error message. I notice while changing RISC-V's loads and stores to use RegClassByHwMode and got a non-descriptive error from `T.getRegisterClass(OpRC)` when parsing the InstAliases. Pull Request: llvm#168444
|
Better error message and test added in follow-up change #170790. This should hopefully address the comment. I could merge the two into one commit, but if you are okay with me landing this one first I would prefer that since it's a bit simpler on my side. |
arichardson
deleted the
users/arichardson/spr/tablegen-report-a-better-error-when-an-instalias-does-not-use-a-regclass
branch
…t use a RegClass Also fix the missing space in the error message. I notice while changing RISC-V's loads and stores to use RegClassByHwMode and got a non-descriptive error from `T.getRegisterClass(OpRC)` when parsing the InstAliases. Reviewed By: arsenm Pull Request: llvm/llvm-project#168444
…Class Also fix the missing space in the error message. I notice while changing RISC-V's loads and stores to use RegClassByHwMode and got a non-descriptive error from `T.getRegisterClass(OpRC)` when parsing the InstAliases. Reviewed By: arsenm Pull Request: llvm#168444
Also fix the missing space in the error message. I notice while changing
RISC-V's loads and stores to use RegClassByHwMode and got a non-descriptive
error from
T.getRegisterClass(OpRC)when parsing the InstAliases.