[CLANG] Fixes the issue with using bool in builtin_bswapg #169285
Conversation
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
llvmbot
added
clang
|
@llvm/pr-subscribers-clang Author: Ebin Jose (ebinjose02) ChangesFixes #168690 Full diff: https://github.com/llvm/llvm-project/pull/169285.diff 2 Files Affected:
diff --git a/clang/lib/CodeGen/CGBuiltin.cpp b/clang/lib/CodeGen/CGBuiltin.cpp
index 93f691e4c2267..8bcc2c8e7d8fe 100644
--- a/clang/lib/CodeGen/CGBuiltin.cpp
+++ b/clang/lib/CodeGen/CGBuiltin.cpp
@@ -3653,6 +3653,8 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID,
Value *ArgValue = EmitScalarExpr(E->getArg(0));
llvm::IntegerType *IntTy = cast<llvm::IntegerType>(ArgValue->getType());
assert(IntTy && "LLVM's __builtin_bswapg only supports integer variants");
+ if (IntTy->getBitWidth() == 1)
+ return RValue::get(ArgValue);
assert(((IntTy->getBitWidth() % 16 == 0 && IntTy->getBitWidth() != 0) ||
IntTy->getBitWidth() == 8) &&
"LLVM's __builtin_bswapg only supports integer variants that has a "
diff --git a/clang/test/CodeGen/builtin_bswapg.cpp b/clang/test/CodeGen/builtin_bswapg.cpp
new file mode 100644
index 0000000000000..8e9af98a58d35
--- /dev/null
+++ b/clang/test/CodeGen/builtin_bswapg.cpp
@@ -0,0 +1,8 @@
+// RUN: %clang_cc1 -triple x86_64 -O0 -emit-llvm -o - %s | FileCheck %s
+
+auto test_bswapg(bool c) {
+ return __builtin_bswapg(c);
+}
+
+// CHECK-LABEL: define{{.*}} i1 @_Z11test_bswapgb(
+// CHECK: ret i1 %{{.*}}
|
|
@llvm/pr-subscribers-clang-codegen Author: Ebin Jose (ebinjose02) ChangesFixes #168690 Full diff: https://github.com/llvm/llvm-project/pull/169285.diff 2 Files Affected:
diff --git a/clang/lib/CodeGen/CGBuiltin.cpp b/clang/lib/CodeGen/CGBuiltin.cpp
index 93f691e4c2267..8bcc2c8e7d8fe 100644
--- a/clang/lib/CodeGen/CGBuiltin.cpp
+++ b/clang/lib/CodeGen/CGBuiltin.cpp
@@ -3653,6 +3653,8 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID,
Value *ArgValue = EmitScalarExpr(E->getArg(0));
llvm::IntegerType *IntTy = cast<llvm::IntegerType>(ArgValue->getType());
assert(IntTy && "LLVM's __builtin_bswapg only supports integer variants");
+ if (IntTy->getBitWidth() == 1)
+ return RValue::get(ArgValue);
assert(((IntTy->getBitWidth() % 16 == 0 && IntTy->getBitWidth() != 0) ||
IntTy->getBitWidth() == 8) &&
"LLVM's __builtin_bswapg only supports integer variants that has a "
diff --git a/clang/test/CodeGen/builtin_bswapg.cpp b/clang/test/CodeGen/builtin_bswapg.cpp
new file mode 100644
index 0000000000000..8e9af98a58d35
--- /dev/null
+++ b/clang/test/CodeGen/builtin_bswapg.cpp
@@ -0,0 +1,8 @@
+// RUN: %clang_cc1 -triple x86_64 -O0 -emit-llvm -o - %s | FileCheck %s
+
+auto test_bswapg(bool c) {
+ return __builtin_bswapg(c);
+}
+
+// CHECK-LABEL: define{{.*}} i1 @_Z11test_bswapgb(
+// CHECK: ret i1 %{{.*}}
|
ebinjose02
force-pushed
the
bswapg_issue
branch
from
fcf359f to
8702e84
Compare
🐧 Linux x64 Test Results
✅ The build succeeded and all tests passed. |
Prevents assertion in CGBuiltin for i1 - returns identity. Created test file for the same.
ebinjose02
force-pushed
the
bswapg_issue
branch
from
8702e84 to
4baf6aa
Compare
clang/test/CodeGen/builtin_bswapg.c
Outdated
| // RUN: %clang_cc1 -triple x86_64 -O0 -emit-llvm -o - %s | FileCheck %s | ||
| #include <stdbool.h> | ||
| bool test_bswapg(bool c) { | ||
| return __builtin_bswapg(c); |
There was a problem hiding this comment.
Is there some existing test file where we can add this?
There was a problem hiding this comment.
There is a testfile that check __builtin_bswapg along with other builtins (test/codegen/builtins.c) . I can modify this file.
clang/lib/CodeGen/CGBuiltin.cpp
Outdated
| @@ -3583,6 +3653,8 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, | |||
| Value *ArgValue = EmitScalarExpr(E->getArg(0)); | |||
| llvm::IntegerType *IntTy = cast<llvm::IntegerType>(ArgValue->getType()); | |||
| assert(IntTy && "LLVM's __builtin_bswapg only supports integer variants"); | |||
| if (IntTy->getBitWidth() == 1) | |||
There was a problem hiding this comment.
Maybe if (IntTy->getBitWidth() == 1 ||IntTy->getBitWidth() == 8)?
Added test to an already existin test file
|
It looks like this isn't merging cleanly; please update your branch. |
There were no conflicts showing up. Still I have updated the ticket. Thanks |
|
@ebinjose02 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
Prevents assertion in CGBuiltin for i1 - returns identity. Created test file for the same. Fixes llvm#168690.
3 participants
Fixes #168690
Prevents assertion in CGBuiltin for i1 - returns identity. Created test file for the same.