[libc++] std::barrier uses native wait #171041
Open
+1
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure why but the current
std::barrier's wait implementation is polling on the loop with sleep instead of using the native waitBefore this change, on the CI runner , lost_wakeup.pass.cpp was the slowest test , which uses
std::barrier===
macOS CXX23
Before:
After
===
Linux CXX23:
Before
After:
No longer in the slowest tests list
===
Windows:
Before
After
No longer in the slowest test list
This change should also indirectly fix the performance issue of
std::barrierdescribed in #123855