Skip to content

[libc++] Implement P2442R1 std::views::chunk #171234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anonymouspc wants to merge 34 commits into
base: main
Choose a base branch
from
+1,501 −50
Open

[libc++] Implement P2442R1 std::views::chunk #171234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
25afd3b
[libc++] Implement P2242R1 `std::views::chunk`
anonymouspc Dec 8, 2025
f5f374f
post-code-review
anonymouspc Dec 9, 2025
b97b20c
clang-format
anonymouspc Dec 9, 2025
1b4367d
add nodiscard attributes
anonymouspc Dec 9, 2025
2f19c92
nodiscard tests
anonymouspc Dec 9, 2025
09f85db
no_unique_address tests
anonymouspc Dec 9, 2025
a33c1be
clang-format
anonymouspc Dec 9, 2025
5704a7b
list is not constexpr until C++26, thus not testable in C++23
anonymouspc Dec 9, 2025
0bce4e1
clang-format
anonymouspc Dec 9, 2025
202a86c
Apply suggestion from @H-G-Hristov
anonymouspc Dec 9, 2025
99d5384
revert BUILD.gn
anonymouspc Dec 9, 2025
26cd668
Apply suggestion from @H-G-Hristov
anonymouspc Dec 9, 2025
70b8d13
Apply suggestion from @H-G-Hristov
anonymouspc Dec 9, 2025
ff2fa8e
make views::chunk(n) to be static operator() <- **needs to be tested**
anonymouspc Dec 9, 2025
e63f929
update test/std
anonymouspc Dec 9, 2025
078190a
clang-format
anonymouspc Dec 9, 2025
f420def
clang-format
anonymouspc Dec 9, 2025
9f03400
get rid of span
anonymouspc Dec 9, 2025
89fe519
get rid of span
anonymouspc Dec 9, 2025
e7f4b4d
test/iter
anonymouspc Dec 9, 2025
11e7466
clang-format
anonymouspc Dec 9, 2025
f1f97af
update nodiscard tests and no_unqiue_address_tests
anonymouspc Dec 9, 2025
5eead26
clang-format
anonymouspc Dec 9, 2025
ca3055a
Update libcxx/docs/ReleaseNotes/22.rst
anonymouspc Dec 9, 2025
dafb95e
noexcept test
anonymouspc Dec 9, 2025
996918d
add nested-iterator tests
anonymouspc Dec 9, 2025
4d828b6
clang-format
anonymouspc Dec 9, 2025
73a7a48
small fix
anonymouspc Dec 9, 2025
dad914f
fix no_unique_address
anonymouspc Dec 11, 2025
52a93dc
get rid of auto
anonymouspc Dec 11, 2025
f08769e
clang-format
anonymouspc Dec 11, 2025
fa5dda5
clang-format
anonymouspc Dec 11, 2025
ec3c83c
retrigger CI build
anonymouspc Dec 11, 2025
7ed4aab
you, msvc
anonymouspc Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libcxx/docs/FeatureTestMacroTable.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ Status
---------------------------------------------------------- -----------------
``__cpp_lib_ranges_as_rvalue`` ``202207L``
---------------------------------------------------------- -----------------
``__cpp_lib_ranges_chunk`` *unimplemented*
``__cpp_lib_ranges_chunk`` ``202202L``
---------------------------------------------------------- -----------------
``__cpp_lib_ranges_chunk_by`` ``202202L``
---------------------------------------------------------- -----------------
Expand Down
1 change: 1 addition & 0 deletions libcxx/docs/ReleaseNotes/22.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ Implemented Papers
- P2835R7: Expose ``std::atomic_ref``'s object address (`Github <https://llvm.org/PR118377>`__)
- P2944R3: Comparisons for ``reference_wrapper`` (`Github <https://llvm.org/PR105424>`__)
- P3168R2: Give ``std::optional`` Range Support (`Github <https://llvm.org/PR105430>`__)
- P2442R1: P2442R1: Windowing range adaptors: ``views::chunk`` and ``views::slide`` (`Github <https://llvm.org/PR171234>`__) (Implemented ``views::slide`` only)

Improvements and New Features
-----------------------------
Expand Down
2 changes: 1 addition & 1 deletion libcxx/docs/Status/Cxx23Papers.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"`P2387R3 <https://wg21.link/P2387R3>`__","Pipe support for user-defined range adaptors","2022-02 (Virtual)","|Complete|","19","`#105183 <https://github.com/llvm/llvm-project/issues/105183>`__",""
"`P2440R1 <https://wg21.link/P2440R1>`__","``ranges::iota``, ``ranges::shift_left`` and ``ranges::shift_right``","2022-02 (Virtual)","|Partial|","","`#105184 <https://github.com/llvm/llvm-project/issues/105184>`__","Only ``ranges::iota`` is implemented."
"`P2441R2 <https://wg21.link/P2441R2>`__","``views::join_with``","2022-02 (Virtual)","|Complete|","21","`#105185 <https://github.com/llvm/llvm-project/issues/105185>`__",""
"`P2442R1 <https://wg21.link/P2442R1>`__","Windowing range adaptors: ``views::chunk`` and ``views::slide``","2022-02 (Virtual)","","","`#105187 <https://github.com/llvm/llvm-project/issues/105187>`__",""
"`P2442R1 <https://wg21.link/P2442R1>`__","Windowing range adaptors: ``views::chunk`` and ``views::slide``","2022-02 (Virtual)","|Partial|","22","`#105187 <https://github.com/llvm/llvm-project/issues/105187>`__","Only ``views::chunk`` is implemented."
"`P2443R1 <https://wg21.link/P2443R1>`__","``views::chunk_by``","2022-02 (Virtual)","|Complete|","18","`#105188 <https://github.com/llvm/llvm-project/issues/105188>`__",""
"","","","","","",""
"`P0009R18 <https://wg21.link/P0009R18>`__","mdspan: A Non-Owning Multidimensional Array Reference","2022-07 (Virtual)","|Complete|","18","`#105189 <https://github.com/llvm/llvm-project/issues/105189>`__",""
Expand Down
1 change: 1 addition & 0 deletions libcxx/include/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,6 +703,7 @@ set(files
__ranges/all.h
__ranges/as_rvalue_view.h
__ranges/chunk_by_view.h
__ranges/chunk_view.h
__ranges/common_view.h
__ranges/concepts.h
__ranges/container_compatible_range.h
Expand Down
Loading
Loading