fix: handle EVENT_MSG in handle_msg and register subscriptions via subscribe_with_id_to#72
Open
dadofsambonzuki wants to merge 2 commits into
Open
fix: handle EVENT_MSG in handle_msg and register subscriptions via subscribe_with_id_to#72dadofsambonzuki wants to merge 2 commits into
dadofsambonzuki wants to merge 2 commits into
Conversation
is much more stable
…bscribe_with_id_to
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes EVENT messages being silently dropped in handle_msg because the SDK uses
is_EVENT_MSG()notis_EVENT(). Also registers subscriptions viasubscribe_with_id_toso events route through both handle_msg and handle callbacks.Changes
handle_msg: handle EVENT messages viais_EVENT_MSG(), handle OK messages, add return after CLOSEDhandle: wrapped in try/except with error logging_broadcast_subscription: addsubscribe_with_id_toalongside raw REQ_replay_cached_subscriptions: addsubscribe_with_id_toalongside raw REQ