feat(bridge): push notification on deposit settlement [ENG-275]#392
Open
islandbitcoin wants to merge 1 commit into
Open
feat(bridge): push notification on deposit settlement [ENG-275]#392islandbitcoin wants to merge 1 commit into
islandbitcoin wants to merge 1 commit into
Conversation
Fires a best-effort push when a Bridge USDT deposit settles via the IBEX crypto.received webhook (the must-have launch gate). Mirrors the existing sendBridgeWithdrawalNotification pattern: - new src/app/bridge/send-deposit-notification.ts - wired at the crypto-receive settlement success (idempotent — inside the per-txHash lock; fires once) - notification.bridgeDeposit i18n phrases (en + es) Withdrawal-completion push already exists (transfer.ts) — this completes the deposit side. IBEX→USD currency display mirrors the withdrawal notif. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENG-275 — Push notification on /deposit and /transfer
Completes the deposit side of ENG-275. The withdrawal-completion push already exists (
transfer.ts→sendBridgeWithdrawalNotificationBestEffortontransfer.completed/failure), so this PR adds the missing deposit settlement push (the must-have launch gate).Where it fires
A Bridge USDT deposit settles when IBEX sends its
crypto.receivedwebhook. The push is fired at the success point ofservices/ibex/webhook-server/routes/crypto-receive.ts, where:findByBridgeEthereumAddress— so it's Bridge-specific),txHashLockServiceblock → idempotent, fires once per deposit.What's added
src/app/bridge/send-deposit-notification.ts—sendBridgeDepositNotification(BestEffort), mirroring the existing withdrawal-notification function (resolve account→user→deviceTokens,PushNotificationsService().sendFilteredNotification, best-effort token-cleanup + warn).notification.bridgeDeposit.{title,body}i18n phrases inen.json+es.json.Notes
Acceptance
crypto.receivedsettles) triggers a push; a successful withdrawal (transfer.completed) already does. Mobile receives + displays (Nick's client work).🤖 Generated with Claude Code