Added tests to increase coverage %#300
Conversation
Adds sonar-project.properties and a GitHub Actions workflow that runs tests with coverage and pushes results to SonarQube Cloud. Made-with: Cursor
- Skip integration tests when API keys are not available - Set fail-fast: false so Node 20 tests still run if Node 22 fails - Update action versions from v2 to v4 - Allow SonarQube workflow to continue even if tests error Made-with: Cursor
Made-with: Cursor
- Add generate-metrics.js to produce test counts and classification - Post test inventory table (unit/integration/count/coverage) to GitHub Actions step summary for team visibility Made-with: Cursor
Dynamically injects unit/integration test counts into the sonar.projectDescription before each scan so the data appears on the SonarCloud project overview page. Made-with: Cursor
Made-with: Cursor
- Remove run_tests.yml (redundant with sonarqube.yml) - Remove forked_run_tests.yml (not needed for fork) - Remove sonar.projectDescription injection from sonarqube.yml Made-with: Cursor
Cover merge_variables and nested object handling in cards.create, HTTP agent for non-TLS, 500 errors without error body, stream-based form data, null value edge cases, and network error handling in resourceBase. Made-with: Cursor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the project's test suite and infrastructure. The primary goal was to achieve comprehensive code coverage by addressing previously untested code paths in core functionalities. Additionally, new tooling has been introduced to generate project metrics and integrate with SonarQube for continuous code quality analysis. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully increases test coverage by adding several new tests for edge cases in cards.js and resourceBase.js. Additionally, it introduces a script for generating repository metrics and a configuration file for SonarQube. My review focuses on these new files, with suggestions to improve the robustness of the metrics script and correct the SonarQube configuration to ensure test coverage is reported accurately.
| } catch { | ||
| return { name: path.basename(repoRoot), version: "unknown", repository: "" }; | ||
| } |
There was a problem hiding this comment.
The catch block is empty. While there's a fallback mechanism, swallowing the error silently is not ideal. If package.json is unreadable or malformed, the script will proceed with default values without any indication of what went wrong. It's a good practice to log the error to stderr to aid in debugging.
} catch (error) {
console.error('Failed to read or parse package.json:', error);
return { name: path.basename(repoRoot), version: "unknown", repository: "" };
}|
|
||
| function classifyTests() { | ||
| const testDir = path.join(repoRoot, "test"); | ||
| const allTestFiles = findTestFiles(testDir, /\.(test|spec)\.js$|^(?!setup)[a-zA-Z]+\.js$/); |
There was a problem hiding this comment.
The regular expression to find test files seems a bit fragile. The part ^(?!setup)[a-zA-Z]+\.js$ will only match files whose names consist exclusively of alphabetic characters (e.g., cards.js), and will fail to match test files with names containing numbers, hyphens, or other characters (e.g., my-test-1.js). This could lead to an inaccurate count of test files if naming conventions change in the future. Consider making the pattern less restrictive to allow for more characters in the filename.
| sonar.test.inclusions=test/**/*.js,test/integration/**/*.test.js | ||
| sonar.exclusions=test/** |
There was a problem hiding this comment.
There are a couple of potential issues with the SonarQube configuration:
sonar.exclusions=test/**on line 10 might prevent test files from being analyzed for coverage. Since you've already separated source and test files withsonar.sources=libandsonar.tests=test, this exclusion is redundant and could be harmful. It's generally recommended to remove it and rely on thesonar.sourcesandsonar.testsproperties for separation.- The pattern
test/integration/**/*.test.jsinsonar.test.inclusionson line 9 is redundant, as it's already covered bytest/**/*.js. You can simplify this to justsonar.test.inclusions=test/**/*.js.
sonar.test.inclusions=test/**/*.js
1 participant
The 96.05% line / 94.83% branch coverage was accurate — there were genuinely untested code paths in cards.js and resourceBase.js.
8 new tests covering:
cards.create with merge_variables object (JSON stringification path)
cards.create with nested object params (bracket-notation expansion)
HTTP agent for non-TLS connections
500 errors without error body
Stream-based form data
Null values in multipart and URL-encoded form data
Network error handling
Result: 102 tests passing, 100% statements, branches, functions, and lines