Enforce minimum unit quantity of 1 in product variant form#2547
Open
Huncsuga wants to merge 2 commits into
Open
Enforce minimum unit quantity of 1 in product variant form#2547Huncsuga wants to merge 2 commits into
Huncsuga wants to merge 2 commits into
Conversation
Add minValue(1) to the unit quantity form field on ProductVariantResource and clamp DefaultPriceFormatter's unitQty to 1 in the constructor, so a zero or negative value can't be entered or divided by when computing unit prices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents the Unit Quantity field from accepting values lower than
1.This avoids invalid inventory configurations that can cause a
DivisionByZeroErrorwhen adding a product or product variant to the cart.Fixes #2546