Open
Conversation
simplify globalThis check per sbc100 suggestion add sock opt constants to struct_info json and use cDefs instead of hardcoded vals per sbc100 feedback extract doh dns resolution out of this pr per sbc100 req to split into sep pr - _emscripten_lookup_name now uses std dns only add asyncify guard w error msg at top of file per sbc100 add direct sockets section to networking rst docs per sbc100 fix sockpair naming to use monotonic counter instead of Object.keys().length which can produce dupes after close getsockname getpeername errno propagation already correct fionread udp datagram handling already addressed stream_ops read write already handle udp dgram shape connect failure already preserves bound state _emscripten_lookup_name deps and ret type already fixed dns address_map already stores string not array https://claude.ai/code/session_013tMRcS8HLZpNDZ4vLoNp7C
dns resolution here uses standard emscripten fake dns, not doh. doh will be a separate optional feature in its own pr. https://claude.ai/code/session_013tMRcS8HLZpNDZ4vLoNp7C
per the Direct Sockets spec, set dnsQueryType to 'ipv4' for AF_INET sockets so Chrome resolves the correct record type. previously only AF_INET6 was explicit; AF_INET relied on OS auto-detection which could return an IPv6 address for an IPv4 socket. https://claude.ai/code/session_013tMRcS8HLZpNDZ4vLoNp7C
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.