refactor!: rename credential field apikey to api_key - #4
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Canonicalizes credential field naming on snake_case:
apikey→api_key(inFieldFactoryTrait,ClientFactoryconfig reads including the Azure arm, README examples, and tests).base_url/endpoint/model/deployment/api_versionwere already snake_case.Breaking for any stored config created before this lands — acceptable pre-1.0.0, no migration shipped.
SensitiveDataProcessor::SENSITIVE_KEYSintentionally keeps both spellings as a defensive measure for third-party providers.PR chain (stacked on #2; each retargets as its base merges): Grok/xAI dedupe →
api_keyrename → masked credentials → CSP. All are pre-1.0.0, so the breaking changes need no migration.Test plan
api_key; one legacy-spelling test retained for the defensive path.vendor/bin/phpcsexits 0.🤖 Generated with Claude Code