Identities with unittests simplified#21
Draft
boekhorstb1 wants to merge 5 commits intomaintaina-com:FRAMEWORK_6_0from
Draft
Identities with unittests simplified#21boekhorstb1 wants to merge 5 commits intomaintaina-com:FRAMEWORK_6_0from
boekhorstb1 wants to merge 5 commits intomaintaina-com:FRAMEWORK_6_0from
Conversation
- adding new database structure to handle mutliple public keys - adding translation options and help files - Adding vanilla javascript for extra information given in identity configuration pages
- repairing old unit tests (removing few non working ones), working for php7.4 on PHPUNIT 9.5 - fixing workflows
Author
|
Btw tests are running through, only one risky test left which I could delete (not sure):
|
ralflang
approved these changes
Oct 24, 2023
|
Note the CI is still failing! |
ralflang
approved these changes
Oct 24, 2023
Author
|
Some Issues with migration script found by @midahp , will check later |
|
@boekhorstb1 The PR has been approved but is still in draft stage. How to move forward with this? |
Author
|
I will try and see if I can still fix the CI @ralflang. Then I will test the code ones more. |
Author
|
ok, so for php7.4 and phpunit 9.5 the tests are wokring now and ci is running through as you can see @ralflang. I guess an update of the tests to work with php8 requires another MR an this one... Im just a bit afraid to go through with this update because it needs a db migration... it would be great to have a testscenario for that. Its this commit that Im afraid of: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added migration-script to migrate keys from previous imp automatically, see: migration/4_imp_smime.php