[INFRA-473] - feat(plane-enterprise): add live-exporter service and EXPORT_QUEUE_NAME env - #277
Closed
akshat5302 wants to merge 5 commits into
Closed
[INFRA-473] - feat(plane-enterprise): add live-exporter service and EXPORT_QUEUE_NAME env#277akshat5302 wants to merge 5 commits into
akshat5302 wants to merge 5 commits into
Conversation
…ORT_QUEUE_NAME env - Add live-exporter Deployment (same image as live, LIVE_MODE=exporter, no HTTP port) - Add AMQP_URL to live-secrets (Secret) for live and live-exporter - Add EXPORT_QUEUE_NAME to live-vars ConfigMap (default: plane-exports) - Declare services.live_exporter and env.export_queue_name in values.yaml - Add Rancher form entries in questions.yml - Document in README under Live Exporter and live_env_existingSecret sections - Bump chart version 3.0.0 → 3.1.0 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThe Helm chart adds a configurable Live Exporter Deployment for PDF/DOCX jobs, RabbitMQ export queue settings, conditional AMQP configuration, required live secret documentation, and chart version ChangesLive Exporter
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant HelmValues
participant LiveEnvTemplate
participant Kubernetes
participant LiveExporter
participant RabbitMQ
HelmValues->>LiveEnvTemplate: Set export and RabbitMQ settings
LiveEnvTemplate->>Kubernetes: Render live environment values
HelmValues->>Kubernetes: Enable Live Exporter
Kubernetes->>LiveExporter: Start configured replicas
LiveExporter->>RabbitMQ: Consume jobs from the export queue
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1⚔️ Resolve merge conflicts 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Linked to Plane Work Item(s) References This comment was auto-generated by Plane |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@charts/plane-enterprise/questions.yml`:
- Around line 276-302: Indent the entire Live Exporter question entry beginning
with services.live_exporter.enabled, including its label, settings, and
subquestions, by two spaces so it remains within the existing questions sequence
and produces valid YAML.
In `@charts/plane-enterprise/README.md`:
- Around line 467-481: Add services.live_exporter.pullPolicy to the Live
Exporter Deployment settings table, documenting its default as Always and
describing it as the image pull policy so operators can configure it from the
README.
In `@charts/plane-enterprise/templates/workloads/live-exporter.deployment.yaml`:
- Around line 46-51: Update the environment-variable rendering in the
live-exporter deployment so LIVE_MODE remains authoritative: render
.Values.extraEnv before the fixed LIVE_MODE entry, or explicitly filter/reject
any LIVE_MODE supplied through extraEnv. Preserve the required LIVE_MODE value
of "exporter" and use the existing extraEnv handling.
In `@charts/plane-enterprise/values.yaml`:
- Around line 279-283: Increase the exporter’s default memoryRequest from 50Mi
to at least 500Mi in charts/plane-enterprise/values.yaml and
charts/plane-enterprise/questions.yml at the specified ranges, and make the same
default change in charts/plane-enterprise/README.md. Keep memoryLimit and CPU
settings unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 3ef94515-0997-4ce8-a2b7-7cc2edaca69c
📒 Files selected for processing (6)
charts/plane-enterprise/Chart.yamlcharts/plane-enterprise/README.mdcharts/plane-enterprise/questions.ymlcharts/plane-enterprise/templates/config-secrets/live-env.yamlcharts/plane-enterprise/templates/workloads/live-exporter.deployment.yamlcharts/plane-enterprise/values.yaml
…ployment Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Defaults to licenseDomain with protocol inferred from SSL settings. Configurable via env.export_download_base_url. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
Author
|
closing in favor of PR#256 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the
live-exporterDeployment and two new env vars toplane-enterprise, wiring up the background PDF/DOCX export worker introduced in plane-ee#8680.New file —
templates/workloads/live-exporter.deployment.yaml: a Deployment that reuses themakeplane/live-commercialimage withLIVE_MODE=exporter. No Service or HTTP port — pure queue consumer.templates/config-secrets/live-env.yaml—AMQP_URLadded to thelive-secretsSecret (alongsideREDIS_URL);EXPORT_QUEUE_NAMEadded to thelive-varsConfigMap:Chart version bumped
3.0.0 → 3.1.0.Why
plane-ee#8680 moves page PDF/DOCX export out of the live request path into a dedicated RabbitMQ-backed worker process (
LIVE_MODE=exporter). Without this chart change, Kubernetes deployments have no way to run the exporter and thelivepod has no AMQP connection to publish export jobs.Scope / behavior
live-exporterDeploymentservices.live_exporter.enabled: true). Set tofalseto skip.AMQP_URLinlive-secretsapp-secrets). Whenlive_env_existingSecretis set, the chart-managed Secret is skipped entirely and the operator must includeAMQP_URLin their external secret.EXPORT_QUEUE_NAMEinlive-vars"plane-exports".The
liveDeployment itself is not modified.Upgrade notes
Operators using
live_env_existingSecretmust addAMQP_URL(andLIVE_SERVER_SECRET_KEYif not already present) to their external secret — see the READMElive_env_existingSecrettable.Testing
helm lint— 0 failures.helm template(defaults):helm template --set services.live_exporter.enabled=false— nolive-exporterresources rendered.Related
🤖 Generated with Claude Code
Summary by CodeRabbit
plane-exports.