[INFRA-481] - feat(plane-enterprise): add Microsoft Teams integration secrets to silo - #281
[INFRA-481] - feat(plane-enterprise): add Microsoft Teams integration secrets to silo#281akshat5302 wants to merge 1 commit into
Conversation
Add MS_TEAMS_CLIENT_ID, MS_TEAMS_CLIENT_SECRET, MS_TEAMS_TENANT_ID, MS_TEAMS_APP_ID (default empty) and MS_TEAMS_APP_TYPE (default MultiTenant) to silo secrets, values.yaml, and questions.yml. Bump version 3.1.0 → 3.1.1. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
WalkthroughThe enterprise Helm chart adds Microsoft Teams connector configuration, defaults, and conditional silo Secret values. The chart version increases from ChangesMicrosoft Teams connector
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Linked to Plane Work Item(s) This comment was auto-generated by Plane |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@charts/plane-enterprise/questions.yml`:
- Line 448: Update the show_subquestion_if field in the question definition to
use the string value "true" rather than the YAML boolean true, preserving the
expected string condition format.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: eedbb41d-9a9e-4286-a3ed-bffdd2dc093d
📒 Files selected for processing (4)
charts/plane-enterprise/Chart.yamlcharts/plane-enterprise/questions.ymlcharts/plane-enterprise/templates/config-secrets/silo.yamlcharts/plane-enterprise/values.yaml
| type: boolean | ||
| default: false | ||
| group: "Silo Connectors" | ||
| show_subquestion_if: true |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
rg -n -C 2 'show_subquestion_if' charts/plane-enterprise/questions.yml
helm lint charts/plane-enterpriseRepository: makeplane/helm-charts
Length of output: 4572
🌐 Web query:
Rancher questions.yml show_subquestion_if field type string true
💡 Result:
In Rancher's questions.yml file, the show_subquestion_if field is a string used to define conditional logic for displaying subquestions [1][2]. When show_subquestion_if is set to "true" (as a string value), it means the associated subquestions will be rendered in the Rancher UI only when the parent question's value evaluates to true [1][3][4]. This is commonly used with boolean input types [3][5]. For example, if you have a boolean setting (e.g., enabled: true), setting show_subquestion_if: "true" on the parent question will cause the defined subquestions to appear when that setting is enabled [3][4]. Key technical details include: - Functionality: The field controls the visibility of the subquestions array based on the parent variable's value [1][2]. - Syntax: It accepts string values, such as "true" or specific option matches (e.g., "serviceType=NodePort") [1][2][4]. - Constraints: While show_subquestion_if is a standard field for question objects, it cannot be nested inside the subquestions array itself (i.e., subquestions cannot contain their own subquestions or show_subquestion_if keys) [1][2][6]. For more complex conditional requirements, the show_if field is used to control the visibility of the current variable itself based on other inputs [1][7].
Citations:
- 1: https://ranchermanager.docs.rancher.com/how-to-guides/new-user-guides/helm-charts-in-rancher/create-apps
- 2: https://documentation.suse.com/cloudnative/rancher-manager/v2.9/en/cluster-admin/helm-charts-in-rancher/create-apps.html
- 3: https://github.com/rancher/questions-yml-examples
- 4: https://github.com/rancher/helm3-charts
- 5: https://github.com/rancher/rancher/wiki/Understanding-How-Rancher-Configures-Helm-Charts
- 6: https://ranchermanager.docs.rancher.com/v2.13/how-to-guides/new-user-guides/helm-charts-in-rancher/create-apps
- 7: https://ranchermanager.docs.rancher.com/v2.10/how-to-guides/new-user-guides/helm-charts-in-rancher/create-apps
🌐 Web query:
site:gihub.com rancher/questions-yml-examples show_subquestion_if: true boolean Rancher
💡 Result:
In Rancher's questions.yml file, the show_subquestion_if field is used to conditionally display subquestions based on the value of a parent question [1][2][3]. When working with a boolean type question, you can use show_subquestion_if to trigger the visibility of nested subquestions when the boolean is set to true [1][2][3]. Usage Example: If you have a primary boolean question (e.g., enableFeature) and you want to show subquestions only when it is checked (true), your questions.yml configuration would look similar to this: questions: - variable: enableFeature label: "Enable Optional Feature" type: boolean default: false show_subquestion_if: "true" subquestions: - variable: featureOption label: "Feature Option" type: string default: "some-value" In this configuration, the subquestion featureOption will only appear in the Rancher UI when enableFeature is set to true [1][2][3]. Key Notes: - The show_subquestion_if field accepts a string representing the condition, such as "true" for boolean toggles [1][2][3]. - It can also be used for enum types by matching one of the defined options (e.g., show_subquestion_if: "OptionA") [1][2][3]. - Subquestions themselves cannot contain further nested subquestions or additional show_subquestion_if keys [1][2][3].
Citations:
- 1: https://ranchermanager.docs.rancher.com/how-to-guides/new-user-guides/helm-charts-in-rancher/create-apps
- 2: https://ranchermanager.docs.rancher.com/v2.15/how-to-guides/new-user-guides/helm-charts-in-rancher/create-apps
- 3: https://ranchermanager.docs.rancher.com/v2.11/how-to-guides/new-user-guides/helm-charts-in-rancher/create-apps
Keep show_subquestion_if as a string.
show_subquestion_if is expected to hold a string condition, such as "true", so use show_subquestion_if: "true" instead of emitting a YAML boolean at this location.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@charts/plane-enterprise/questions.yml` at line 448, Update the
show_subquestion_if field in the question definition to use the string value
"true" rather than the YAML boolean true, preserving the expected string
condition format.
Source: MCP tools
1 participant
Summary
MS_TEAMS_CLIENT_ID,MS_TEAMS_CLIENT_SECRET,MS_TEAMS_TENANT_ID,MS_TEAMS_APP_ID(default empty) andMS_TEAMS_APP_TYPE(defaultMultiTenant) underservices.silo.connectors.microsoft_teamsinvalues.yamltemplates/config-secrets/silo.yamlwhen the connector is enabledquestions.ymlfor Rancher catalog form3.1.0 → 3.1.1Test plan
helm lint charts/plane-enterprisepasseshelm templaterenders MS Teams secrets whenmicrosoft_teams.enabled=truemicrosoft_teams.enabled=false🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Chores