Repository navigation
Remove ETA flags from search category - #80
Merged
Merged
Conversation
ETA results are gated by a per-account feature flag, so for most accounts --eta-type, --navigation-profile and --origin were accepted but never added an ETA to the response. Drop them rather than expose flags that silently do nothing for most users.
Per the Search team, forward returns an ETA without the feature flag; only category is gated. Restore the flags on forward and remove them from category only, until category supports ETA for every account.
zmofei
changed the title
mattpodwysocki
approved these changes
Oct 6, 2026
mattpodwysocki
left a comment
mattpodwysocki
left a comment
Contributor
There was a problem hiding this comment.
Built it and confirmed directly: --eta-type/--navigation-profile/--origin are gone from search category --help while still present on search forward --help, and passing --eta-type to search category now fails with unexpected argument at exit code 2, matching the changelog. Full suite, fmt, clippy -D warnings all clean. Clean, minimal fix for a real bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #76.
The category endpoint does not currently return
properties.eta, so--eta-type,--navigation-profileand--originare accepted but have no effect. This removes them fromsearch category, same approach as #79.They stay on
search forward, which does return an ETA. We'll add them back to category once it does too.Breaking: scripts passing these flags to
search categorynow fail with an unknown-argument error. Noted in CHANGELOG.md.Not checked: forward ETA against the real API from the CLI (only tested with a direct API call).