Skip to content

feat: allow mouse movement outside terminal #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marc2332 merged 6 commits into from
Jun 6, 2026
Merged

feat: allow mouse movement outside terminal #24

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
88bb753
feat: allow mouse movement outside terminal
marc2332 Apr 11, 2026
035dfb3
Merge branch 'main' into allow-mouse-movement-outside-terminal
marc2332 Apr 18, 2026
385fbcf
clean up
marc2332 Apr 18, 2026
f31cda6
Merge branch 'allow-mouse-movement-outside-terminal' of https://githu…
marc2332 Apr 18, 2026
8f7ff19
fixes and clean up
marc2332 Apr 18, 2026
e3fe965
resolve conflicts
marc2332 Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
127 changes: 76 additions & 51 deletions src/components/panel.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,36 @@ impl Component for Panel {
let mut radio = use_radio(AppChannel::Tabs);
let focus = Focus::new_for_id(self.panel_id);

let mut dimensions = use_state(|| (0.0, 0.0));
let mut cell_size = use_state(Size2D::zero);
let mut terminal_area = use_state(Area::zero);
let mut is_pressed = use_state(|| false);
let mut click_origin = use_state(|| None::<(usize, usize)>);

// Convert a global cursor point into fractional terminal cell
// coordinates, clamped to the terminal area so drags can continue
// outside the viewport.
let to_cell = move |global: CursorPoint| -> Option<(f32, f32)> {
let cell = cell_size.read().to_f64();
if cell.is_empty() {
return None;
}
let area = terminal_area.read().to_f64();
let local_x =
(global.x - area.min_x()).clamp(0.0, (area.width() - cell.width).max(0.0));
let local_y =
(global.y - area.min_y()).clamp(0.0, (area.height() - cell.height).max(0.0));
Some((
(local_y / cell.height) as f32,
(local_x / cell.width) as f32,
))
};

let to_button = |button: Option<MouseButton>| match button {
Some(MouseButton::Middle) => TerminalMouseButton::Middle,
Some(MouseButton::Right) => TerminalMouseButton::Right,
_ => TerminalMouseButton::Left,
};

let (is_active, has_multiple_panels) = {
let state = radio.read();
let tab = state.tabs.iter().find(|t| t.id == self.tab_id).unwrap();
Expand Down Expand Up @@ -124,73 +151,71 @@ impl Component for Panel {
})
.child(
Terminal::new(handle.clone())
.background(bg_color)
.background(bg_color)
.font_size(font_size)
.on_measured(move |(char_width, line_height)| {
dimensions.set((char_width, line_height));
})
.on_measured(move |(char_width, line_height)| cell_size.set(Size2D::new(char_width, line_height)))
.on_sized(move |event: Event<SizedEventData>| terminal_area.set(event.area))
.on_mouse_down({
let handle = handle.clone();
move |e: Event<MouseEventData>| {
move |event: Event<MouseEventData>| {
focus.request_focus();
radio.write_channel(AppChannel::Tabs).tabs.iter_mut().find(|t| t.id == tab_id).unwrap().active_panel = panel_id;
let (char_width, line_height) = *dimensions.read();
let col = (e.element_location.x / char_width as f64).floor() as f32;
let row = (e.element_location.y / line_height as f64).floor() as f32;
click_origin.set(Some((row as usize, col as usize)));
let button = match e.button {
Some(MouseButton::Middle) => TerminalMouseButton::Middle,
Some(MouseButton::Right) => TerminalMouseButton::Right,
_ => TerminalMouseButton::Left,
};
let selection_type = match EventsCombos::pressed(e.element_location)
{
PressEventType::Double => SelectionType::Semantic,
PressEventType::Triple => SelectionType::Lines,
_ => SelectionType::Simple,
};
handle.mouse_down(row, col, button, selection_type);
radio.write_channel(AppChannel::Tabs).tabs.iter_mut()
.find(|tab| tab.id == tab_id).unwrap().active_panel = panel_id;
if let Some((row, col)) = to_cell(event.global_location) {
is_pressed.set(true);
click_origin.set(Some((row as usize, col as usize)));
let selection_type =
match EventsCombos::pressed(event.element_location) {
PressEventType::Double => SelectionType::Semantic,
PressEventType::Triple => SelectionType::Lines,
_ => SelectionType::Simple,
};
handle.mouse_down(row, col, to_button(event.button), selection_type);
}
}
})
.on_mouse_move({
.on_global_pointer_move({
let handle = handle.clone();
move |e: Event<MouseEventData>| {
let (char_width, line_height) = *dimensions.read();
let col = (e.element_location.x / char_width as f64).floor() as f32;
let row = (e.element_location.y / line_height as f64).floor() as f32;
handle.mouse_move(row, col);
move |event: Event<PointerEventData>| {
let global = event.global_location();
if !terminal_area.read().to_f64().contains(global) && !*is_pressed.read() {
return;
}
if let Some((row, col)) = to_cell(global) {
handle.mouse_move(row, col);
}
}
})
.on_mouse_up({
.on_global_pointer_press({
let handle = handle.clone();
move |e: Event<MouseEventData>| {
let (char_width, line_height) = *dimensions.read();
let col = (e.element_location.x / char_width as f64).floor() as f32;
let row = (e.element_location.y / line_height as f64).floor() as f32;
let button = match e.button {
Some(MouseButton::Middle) => TerminalMouseButton::Middle,
Some(MouseButton::Right) => TerminalMouseButton::Right,
_ => TerminalMouseButton::Left,
};
handle.mouse_up(row, col, button);
move |event: Event<PointerEventData>| {
if !*is_pressed.read() {
return;
}
is_pressed.set(false);
let origin = *click_origin.read();
click_origin.set(None);
if button == TerminalMouseButton::Left
&& origin == Some((row as usize, col as usize))
&& let Some(url) = handle.hyperlink_at(row, col)
{
let _ = open::that(url);
match to_cell(event.global_location()) {
Some((row, col)) => {
let button = to_button(event.button());
handle.mouse_up(row, col, button);
if button == TerminalMouseButton::Left
&& origin == Some((row as usize, col as usize))
&& let Some(url) = handle.hyperlink_at(row, col)
{
let _ = open::that(url);
}
}
None => handle.release(),
}
}
})
.on_wheel({
let handle = handle.clone();
move |e: Event<WheelEventData>| {
let (char_width, line_height) = *dimensions.read();
let (mouse_x, mouse_y) = e.element_location.to_tuple();
let col = (mouse_x / char_width as f64).floor() as f32;
let row = (mouse_y / line_height as f64).floor() as f32;
handle.wheel(e.delta_y, row, col);
move |event: Event<WheelEventData>| {
if let Some((row, col)) = to_cell(event.global_location) {
handle.wheel(event.delta_y, row, col);
}
}
}),
)
Expand Down