test: subir cobertura de tests en lambda-core (11.3% -> 87.6%) - #4
Open
marcoslozina wants to merge 1 commit into
Open
marcoslozina wants to merge 1 commit into
marcoslozina wants to merge 1 commit into
Conversation
…onHandler and RequestValidator Adds real behavioral tests for the previously-untested classes in lambda-core: FunctionConfig's hello()/pong() beans, HelloController's reactive request handling, GlobalExceptionHandler's status-mapping and message-sanitization branches, and RequestValidator's Bean Validation integration. Covers edge cases (blank/missing names, error fallbacks, synchronous vs reactive failures, null constraint violations) rather than trivial getter-style assertions. Instruction coverage on lambda-core went from ~11.3% to ~87.6% (560/639 instructions), so the jacocoTestCoverageVerification gate in lambda-core/build.gradle.kts is recalibrated from 6% to 82% (5-point buffer below the new measured baseline, same methodology used to set the original threshold).
marcoslozina
force-pushed
the
test/increase-lambda-core-coverage
branch
from
September 8, 2026 02:28
f13f9bc to
715d656
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumen
Agrega tests reales (no infladores de métrica) para las clases de
lambda-coreque estaban sin cobertura, y recalibra el gate de JaCoCo con el nuevo baseline medido.Clases y casos cubiertos
FunctionConfig(0% → 99.5%): el beanhello()— echo de path/pathParams/queryParams/body, resolución de nombre desde query params, fallback reactivo a "Hello, World!" cuandoHelloHandlerfalla de forma asíncrona (onErrorResume), delegación aGlobalExceptionHandlercuando falla de forma síncrona (excepción lanzada directamente al invocarprocessGreeting), resolución deX-Request-Idcon y sinrequestContext. El beanpong().HelloController(0% → 99.1%):helloGet/helloPost, precedencia de query param sobre body para el nombre, inclusión condicional dename/bodyen la respuesta, fallback a saludo por defecto cuando el handler falla.GlobalExceptionHandler(0% → 70.6%): mapeo de excepción a status HTTP (IllegalArgumentException/ValidationException→ 400,SecurityException→ 403,RuntimeExceptiony excepciones checked → 500), sanitización del mensaje de error (no filtra detalles internos), mensaje genérico cuando el throwable no tiene mensaje, headers de tracing, ausencia de stack trace por defecto. (El branch deINCLUDE_STACK_TRACE=trueno se cubrió — requiere mockear variables de entorno del proceso, no vale la pena la complejidad extra para este proyecto educativo.)RequestValidator(0% → 100%): validación exitosa,ValidationExceptioncon el mensaje de la violación cuando falla una constraint, casonull.No se agregaron tests para
LambdaApplication(soloSpringApplication.run, boilerplate sin lógica) ni tests triviales tipo "el getter devuelve lo que se seteó".Cobertura
Gate de JaCoCo
lambda-core/build.gradle.kts—jacocoTestCoverageVerification.violationRulespasó de 6% a 82% (mismo criterio que la calibración anterior: baseline medido menos 5 puntos de buffer). Confirmé que el gate dispara de verdad: lo subí temporalmente a 95%, corríjacocoTestCoverageVerification --rerun-tasksy falló coninstructions covered ratio is 0.87, but expected minimum is 0.95; después lo volví a bajar a 82%.Validación
./gradlew build --rerun-taskscompleto (incluyelambda-tests, tests de integración vía SAM local) pasa limpio.Test plan
./gradlew :lambda-core:test :lambda-core:jacocoTestReport --rerun-tasks— 30 tests, todos verdes./gradlew build --rerun-taskscompleto pasa