You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The transform.ts file is refactored to standardize expression and statement rendering across control-flow helpers. The #emitIf, #emitForOf, and #emitSwitch functions now use #attrValue() instead of #slice() for condition/test expressions, while body emission switches to a new #blockStmts() helper. The #block helper is updated to emit block bodies via #blockStmts() and single statements via #child(). Additionally, a test fixture is added for a Count component that demonstrates state management, event handling, and conditional rendering.
The title 'fix(tsrx): control flow expressions & text' directly refers to the main changes: fixes to control flow expression handling and text expression formatting in the tsrx transformer.
Description check
✅ Passed
The description clearly explains the two specific issues being fixed with code examples and technical context about concise mode and parentheses wrapping.
Docstring Coverage
✅ Passed
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check
✅ Passed
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
✅ Passed
Check skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches📝 Generate docstrings
Create stacked PR
Commit on current branch
🧪 Generate unit tests (beta)
Create PR with unit tests
Commit unit tests in branch control-flow-fixes
Review rate limit: 4/5 reviews remaining, refill in 12 minutes.
Comment @coderabbitai help to get the list of available commands and usage tips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This example had two issues:
ifexpression as an attribute, so even though it has>it wasn't being wrapped in parentheses--at the root level because of concise mode, but not in control flow tags