Skip to content

feat(tsrx): member expression tag names map to dynamic tags#5

Merged
LuLaValva merged 2 commits into
mainfrom
member-expression-tag-names
Apr 30, 2026
Merged

feat(tsrx): member expression tag names map to dynamic tags#5
LuLaValva merged 2 commits into
mainfrom
member-expression-tag-names

Conversation

@LuLaValva

Copy link
Copy Markdown
Member

In React & Solid, {interpolations} can receive either strings or JSX. Marko uses ${placeholders} for text, but <${dynamicTag}/> for components.

This is not a complete solution for this problem, but it does allow for <input.content> (same as {props.children} in React)

@LuLaValva LuLaValva merged commit 727288a into main Apr 30, 2026
2 checks passed
@coderabbitai

coderabbitai Bot commented Apr 30, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2c7564e6-a994-4100-9179-599a47c33d31

📥 Commits

Reviewing files that changed from the base of the PR and between 81b1873 and 9a94ae8.

⛔ Files ignored due to path filters (2)
  • packages/tsrx/tests/__snapshots__/volar-mappings.txt is excluded by !**/__snapshots__/** and included by **
  • packages/tsrx/tests/fixtures/tag-member-expression/__snapshots__/index.marko is excluded by !**/__snapshots__/** and included by **
📒 Files selected for processing (4)
  • .changeset/ninety-radios-smash.md
  • packages/tsrx/README.md
  • packages/tsrx/src/transform.ts
  • packages/tsrx/tests/fixtures/tag-member-expression/index.tsrx

Walkthrough

This pull request adds support for member expression tag names to the TSRX transpiler. The isDynamic logic in the transform module is updated to treat MemberExpression element IDs as dynamic tags, causing them to be wrapped using the <${...}/> syntax. The documentation is updated with an example mapping for this behavior (<input.content/><${input.content}/>), and a new test fixture is added to validate the member expression tag name handling.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch member-expression-tag-names

Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant