chore: use types from Vite#279
Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughIn 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Appreciate the PR, thanks! |
Description
Use types from
viterather than fromrolldown.Motivation and Context
rolldownis not a dependency / devDeps of this package and is not always possible to import depending on the package manager's behavior. On ecosystem-ci,viteis resolved to the localvitesonode_modules/rolldownwill not be created by npm, thus the type fails to resolve.https://github.com/vitejs/vite-ecosystem-ci/actions/runs/27599464088/job/81596799094
This PR would fix the error above by using the types re-exported from
vite.Screenshots (if appropriate):
Checklist: