fix: prevent OneOf.options()from emitting phantom pairs#2897
Open
JaeHyuckSa wants to merge 1 commit intomarshmallow-code:devfrom
Open
fix: prevent OneOf.options()from emitting phantom pairs#2897JaeHyuckSa wants to merge 1 commit intomarshmallow-code:devfrom
JaeHyuckSa wants to merge 1 commit intomarshmallow-code:devfrom
Conversation
Signed-off-by: JaeHyuck Sa <wogur981208@gmail.com>
lafrech
reviewed
Feb 15, 2026
Member
lafrech
left a comment
lafrech
left a comment
There was a problem hiding this comment.
Hi. Sorry about the delay. Looks good.
Just minor comments.
Thanks.
| "Extra labels will be ignored in options().", | ||
| stacklevel=2, | ||
| ) | ||
| except TypeError: |
Member
There was a problem hiding this comment.
In which case is this exception raised?
| with warnings.catch_warnings(record=True) as w: | ||
| warnings.simplefilter("always") | ||
| oneof = validate.OneOf([1, 2], ["one", "two", "three"]) | ||
| assert len(w) == 1 |
Member
There was a problem hiding this comment.
We might want to check the warning message, kinda like pytest.raises's match argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaced it with zip bounded by the number of choices, added a warning when labels exceed choices, and included the related test coverage.
Related Issue
Fix: #2869