Improvement: Schema tags: added "order" option#654
Closed
vgavro wants to merge 2 commits intomarshmallow-code:devfrom
Closed
Improvement: Schema tags: added "order" option#654vgavro wants to merge 2 commits intomarshmallow-code:devfrom
vgavro wants to merge 2 commits intomarshmallow-code:devfrom
Conversation
Contributor
Author
|
note that this PR is backward-compatible: so if you're relying on alphabetic order of method name it will remain with default sort value. |
Member
|
Thanks for the PR! This is very similar to #600 . I think "order" may be more intuitive than "priority". That said, I'm still not sure whether this is necessary. See the discussion on #600: most use-cases should be covered by using a single |
Member
|
Closing this for now. Further discussion of this should happen in #600 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, if you're using mixins or subclassing marshmallow-sqlalchemy (which is using @post_load for model creation), tags would be invoked in alphabetically order (because they're relying on dir() accessing attribute, which is not obvious anyway, and better be documented?). I think it would be better to pass verbose "order" argument, to make more complex mixins and schema subclassing. Please consider this PR, if you think it's ok I'll add tests and changes in documentation. Thank you.
Use-cases: data changes in @post_load and @pre_load, on which other mixins or subclasses may be relying.