fix: add null guard to toast._container#661
Merged
Merged
Conversation
Member
|
Cool catch, works as expected |
Member
|
you changed the dist files, the changes will get overwritten at the next build. |
wuda-io
approved these changes
Jul 8, 2026
wuda-io
left a comment
Member
There was a problem hiding this comment.
LGTM, but we have to change the .gitignore to ignore the dist files and use the files in package.json to upload the files to npm. Because in this commit there are dist files, but i will merge them for now, they will get overwritten in the next build and release process.
Member
|
@wuda-io could it be this merge is still missing from the v2-dev branch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue Dogfalo#1394
Proposed changes
Correct type for _container and add null guards.
Types of changes
Checklist: