Skip to content

fix: add null guard to toast._container#661

Merged
wuda-io merged 3 commits into
materializecss:mainfrom
thkruz:toast-_container-null
Jul 8, 2026
Merged

fix: add null guard to toast._container#661
wuda-io merged 3 commits into
materializecss:mainfrom
thkruz:toast-_container-null

Conversation

@thkruz

@thkruz thkruz commented Jun 29, 2026

Copy link
Copy Markdown

Closes issue Dogfalo#1394

Proposed changes

Correct type for _container and add null guards.

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • [ x] I have read the CONTRIBUTING document.
  • [ x] My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • [ x] I have added tests to cover my changes.
  • [ x] All new and existing tests passed.

@gselderslaghs

Copy link
Copy Markdown
Member

Cool catch, works as expected
@wuda-io

@gselderslaghs
gselderslaghs requested a review from wuda-io June 30, 2026 05:37
@wuda-io

wuda-io commented Jun 30, 2026

Copy link
Copy Markdown
Member

you changed the dist files, the changes will get overwritten at the next build.
Edit: Oh, I saw that you changed the toast file as well. I will take a closer look later.

@wuda-io wuda-io left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we have to change the .gitignore to ignore the dist files and use the files in package.json to upload the files to npm. Because in this commit there are dist files, but i will merge them for now, they will get overwritten in the next build and release process.

@wuda-io
wuda-io merged commit 7770bfd into materializecss:main Jul 8, 2026
1 check failed
@gselderslaghs

Copy link
Copy Markdown
Member

@wuda-io could it be this merge is still missing from the v2-dev branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants