Skip to content

chore: add typecheck script and enable strict type checking#662

Closed
thkruz wants to merge 1 commit into
materializecss:mainfrom
thkruz:add-typecheck-script
Closed

chore: add typecheck script and enable strict type checking#662
thkruz wants to merge 1 commit into
materializecss:mainfrom
thkruz:add-typecheck-script

Conversation

@thkruz

@thkruz thkruz commented Jun 30, 2026

Copy link
Copy Markdown

Proposed changes

The project had no type-checking step. ESLint is configured with typescript-eslint's recommended ruleset, which only runs syntactic lint rules; it performs no type-checking and there was no tsc invocation anywhere in the npm scripts. As a result, type errors were never caught by npm run lint, CI, or any other command.

Types of changes

It is an adjustment to the build/development process, not a modification to the production code.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • [ x] I have read the CONTRIBUTING document.
  • [ x] My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • [x ] All new and existing tests passed.

@thkruz
thkruz force-pushed the add-typecheck-script branch from 32c3aed to 0538cba Compare July 1, 2026 00:03
@wuda-io

wuda-io commented Jul 8, 2026

Copy link
Copy Markdown
Member

I had in mind, that the building didn't complete with strict type checking. Can you confirm that the building is working fine after this strict checks? thanks

@gselderslaghs

Copy link
Copy Markdown
Member

@wuda-io correct, I made a quick dry-run on this merge request and it turned out there is additional refactoring needed based on strict-type checking within the codebase before this improvement can be merged into dev and main branches

@thkruz eventually you can create an issue describing this pull request describing what is needed to fully complete this improvement feature, as a result a follow up merge implementing strict-type checking within the codebase can be foreseen to provide a complete validation on this improvement merge-request

@thkruz thkruz closed this Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants