fix: borrow value in optional string pattern check - #21
Merged
Conversation
An explicit-presence string field (`optional string` / editions `field_presence = EXPLICIT`) is lowered to an owned `let v: String` binding before running the shared string-rule emitter. The `string.pattern` check passed `v` to `Regex::is_match`, which takes `&str`. An owned `String` does not coerce in argument position, so the generated validator failed to compile (`expected &str, found String`). The shared `emit_string_checks_on` is also used for oneof members, where the match arm binds `v` as `&String` (which coerces), so the bug only hit the `optional` case. Conformance never caught it because its `string.pattern` cases are all plain non-optional fields. Pass `v.as_str()` so the check compiles whether `v` is an owned `String` or a `&String`. Add a render-based regression test covering both paths.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An explicit-presence string field (
optional string/ editionsfield_presence = EXPLICIT) is lowered to an ownedlet v: Stringbinding before running the shared string-rule emitter. Thestring.patterncheck passedvtoRegex::is_match, which takes&str. An ownedStringdoes not coerce in argument position, so the generated validator failed to compile (expected &str, found String).The shared
emit_string_checks_onis also used for oneof members, where the match arm bindsvas&String(which coerces), so the bug only hit theoptionalcase. Conformance never caught it because itsstring.patterncases are all plain non-optional fields.Pass
v.as_str()so the check compiles whethervis an ownedStringor a&String. Add a render-based regression test covering both paths.