Fix "Open theme" button double path concat#880
Open
0x4C4A wants to merge 1 commit intomathoudebine:mainfrom
Open
Fix "Open theme" button double path concat#8800x4C4A wants to merge 1 commit intomathoudebine:mainfrom
0x4C4A wants to merge 1 commit intomathoudebine:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Manjaro ran into issue that open theme button tries to open
{pwd}/{theme_dir}(i.e./home/user/repo/"/home/user/repo/res/themes").Found that this is due to essentially double quoting the arguments of
subprocess.Popen.subprocess.Popenarguments do not need to have extra quotes applied (the documentation recommends validating this with shlex.split()).The submitted change affects only the subprocess.Popen calls and leaves Windows as it was.
Fixes #868