Repository navigation
Conversation
This is to serve as regression tests for: - rejoining a room not working because we skipped seen events during processing - rejected events (due to cascading) being accepted because we didn't persist rejection status in-memory alongside the state group
3 tasks done
devonh
requested changes
Oct 1, 2026
devonh
left a comment
devonh
left a comment
Contributor
There was a problem hiding this comment.
Love the very thorough test descriptions and diagrams. They are very helpful to understand the test intent.
I found just a couple things after puzzling my way through each test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spawning from the discussions in element-hq/synapse#20194
This is to serve as regression tests for:
This cargo cults some chunks of code from #841
Pull Request Checklist