Open
Conversation
This was new in 3.11 so realistically everyone should have it.
|
Thank you for this. I might find it useful next time i touch my bridge. I had to fix that enum in a super hacky way myself so it started on python 3.13. |
durin42
force-pushed
the
push-zlwpukokorkx
branch
2 times, most recently
from
dec3544 to
8657629
Compare
durin42
force-pushed
the
push-zlwpukokorkx
branch
from
8657629 to
8054c4c
Compare
At least, that's what I think happened here. This fixes things so it works again.
durin42
force-pushed
the
push-zlwpukokorkx
branch
from
8054c4c to
8e76c06
Compare
|
Have you not had problems with the protobuf code too? I had to change -if field.label == FieldDescriptor.LABEL_REPEATED:
+if field.is_repeated:
...
-for field_descriptor, field_value in message.ListFields():
+for field_descriptor, field_value in message.ListFields(): |
Contributor
Author
|
I didn't have to touch that. 🤷 This PR is all the patches I needed to make things run fine against my Python 3.13. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing here is terribly exciting. I know the Go bridge is the future but since the docs still point to this one it was worth contributing these fixes upstream.
Checklist