Conversation
The Bash tool no longer rewrites exclamation marks to backslash-bang in
heredocs. Verified: both `<<EOF` and `<< 'EOF'` now pass `!` through
unchanged. Drop the guidance to use Write + `--body-file` for comment
bodies containing `!`, and drop "unescaped bangs" from the bot-comment
corruption signals.
The `${GITHUB_REPOSITORY}` heredoc-quoting guidance stays (that's bash
semantics, not a Claude Code bug), as does the bang-backtick pre-commit
guard (separate slash-command preprocessor issue, #234/#243/#244).
Co-Authored-By: Claude <noreply@anthropic.com>
tend-agent
approved these changes
Apr 19, 2026
tend-agent
pushed a commit
that referenced
this pull request
Apr 19, 2026
PR #317 dropped the heredoc bang-escape warning on the premise that the underlying Claude Code bug was fixed, but the bug still reproduces in this CI harness (Claude Code 2.1.114 on GitHub Actions runners) — every context tested, including both heredoc forms, plain single-quoted, and double-quoted args, still rewrites `!` to `\!`. Without the warning, a bot comment containing an exclamation mark would ship corrupted. Restore the paragraph and broaden it to cover plain-argument `--jq` filters (where `!=` has bitten three times). Also re-add "unescaped bangs" to the review-reviewers corruption signals list. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This was referenced Apr 19, 2026
3 tasks
max-sixty
added a commit
that referenced
this pull request
Apr 22, 2026
The heredoc-specific ! rewriting was fixed in #317, but the Bash tool can still rewrite bare bangs outside heredocs, so the overlay's `(X) | not` form is still the safer construction when authoring jq via bash. Revert to that and re-document the caveat. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Bash tool no longer rewrites exclamation marks to backslash-bang in heredocs. Verified locally — both
<<EOFand<< 'EOF'now pass!through unchanged.Changes:
running-in-ci: drop the paragraph telling agents to use the Write tool +--body-filefor comment bodies containing!. Heredocs withgh ... --bodywork fine again.review-reviewers: drop "unescaped bangs" from the bot-comment corruption signals — no longer a thing to watch for.Kept intentionally:
${GITHUB_REPOSITORY}heredoc-quoting warning (bash semantics around single-quoted heredocs, not a Claude Code bug)..pre-commit-config.yamlbang-backtick guard — that's a separate slash-command preprocessor issue (fix(review): unbreak /review slash command poisoned by\!\` sequence #234/fix(review): remove re-introduced \\!-backtick poison from skill comments #243/fix(review): re-unbreak /review slash command poisoned by PR #226 regression #244), not the heredoc bug.