Open
Conversation
Owner
|
Thanks, I quickly tried this on macOS and got: |
Contributor
Author
|
Thank you, sorry for little mistake.. '"' lost somehow during merging/rebasing.. Can you please try it again? |
Owner
|
While it runs now, the env variables aren't set. I don't think there's a syntax that works on both unix and windows... so probably best to add a new command |
mb21
force-pushed
the
master
branch
2 times, most recently
from
d800848 to
7b1255a
Compare
ExactDoug
pushed a commit
to ExactDoug/panwriter
that referenced
this pull request
Nov 28, 2025
The current npm scripts use Unix-specific syntax that fails on Windows: - Environment variables use Unix syntax (VAR=value) instead of cross-platform - The postinstall script uses Unix 'cp' command which doesn't exist on Windows - Windows developers cannot run npm scripts natively without WSL This change adds proper cross-platform support: 1. Added 'cross-env' dependency (v7.0.3) - Handles environment variable setting across all platforms - Used in: build, electron:dev, website:build scripts 2. Added 'shx' dependency (v0.3.4) - Provides Unix commands (like cp) on all platforms - Used in: postinstall script These are industry-standard packages for Node.js cross-platform compatibility. Scripts updated: - build: Added cross-env for INLINE_RUNTIME_CHUNK - postinstall: Changed cp to shx cp for cross-platform file copying - electron:dev: Added cross-env for BROWSER and ELECTRON_IS_DEV - website:build: Added cross-env for BUILD_PATH, PUBLIC_URL, INLINE_RUNTIME_CHUNK This fixes the issues reported in PR mb21#65 and allows Windows developers to run all npm scripts without modification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix electron:dev npm task to run also on Windows OS.