CI: a build program that ran is known by its compiled file, not by its status line - #38
Merged
Merged
Conversation
…s status line check-deps-and-qt.sh asserted that the qt import-only package runs no build program with `! grep -q 'build.mcpp running'`. mcpp 2026.9.29.5 writes one line per program (`build.mcpp <package> ran <time>`), so that search would pass whether or not a program ran once the CI's mcpp pin moves past it. A program that runs is compiled first into the package's target/, so the check now asks for build.mcpp.bin or build.mcpp.exe there, which holds for every mcpp version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The qt import-only check asserted that no build program ran by searching the build log for
build.mcpp running. mcpp 2026.9.29.5 (mcpp-community/mcpp#742) writes one line per program,build.mcpp <package> ran <time>, so the search would pass whether or not a program ran once this CI's mcpp pin moves to that release.A program that runs is compiled first into the package's
target/, so the check now asks whetherbuild.mcpp.binorbuild.mcpp.exeexists there. Checked in both directions with the build of #742: a package with abuild.mcppleavestarget/.build-mcpp/build.mcpp.bin, and the same package without one leaves nothing. The check holds for the pinned 2026.9.28.3 as well, so this pull request changes no pin.