Skip to content

Conversation

@devanshu-puri
Copy link

Hi @baync180705 @mohitvermax ,

I’ve implemented the preset save & load functionality as discussed:

initail presets
image

SAVING PRESET GIVE A DOWNLOADABLE JSON FILE
image

LOADING IT WITH THE LOADED PRESET
image

Centralized all synthesizer parameters (ADSR, EQ, waveform, octave, rawWave) into a single synthState object.

Added Save Preset feature to export current settings as a JSON file with a timestamp.

Added Load Preset feature to import JSON presets and restore all synth settings.

Wrapped file parsing in try…catch and added basic validation for safety.

Added simple alert feedback for successful save/load or errors.

The core functionality is complete and should meet the original requirements. Optional enhancements like toast notifications, localStorage, and a “Reset to Default” button can be added in the next iteration.

Looking forward to your review!

@MeetCoding
Copy link
Collaborator

Hey @devanshu-puri, great work, but the preset is currently loading only for the ADSR envelope, can you please modify your code to include waveform, octave and equalizer too. I see that you have tried to add EQ preset, but it isn't implemented properly. Also prefer to use camel case wherever applicable.

@devanshu-puri
Copy link
Author

have fixed all issue and all requirement are satisfied now. :)

@baync180705 baync180705 self-requested a review October 23, 2025 06:34
Copy link
Collaborator

@baync180705 baync180705 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @devanshu-puri, the same bug still persists. Only the ADSR values are getting loaded. The waveform, octave, EQ etc retain their default value instead of what should have been as per the previous preset saved.
Kindly look into it once test it locally once. If you need any help in troubleshooting, do let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants