netlink: reduce allocations in marshalMessages - #311
Merged
Conversation
Reduce allocations in marshalMessages by summing their sizes
and then allocating a single buffer to write directly to via
a new marshalInto method.
│ before │ after │
│ sec/op │ sec/op vs base │
MarshalMessages/1-12 60.35µ ± 4% 33.61µ ± 3% -44.32% (p=0.000 n=10)
MarshalMessages/8-12 1537.5µ ± 4% 330.9µ ± 11% -78.47% (p=0.000 n=10)
MarshalMessages/64-12 15.403m ± 5% 1.294m ± 3% -91.60% (p=0.000 n=10)
MarshalMessages/512-12 74.14m ± 17% 11.84m ± 4% -84.03% (p=0.000 n=10)
geomean 3.208m 642.5µ -79.98%
│ before │ after │
│ B/op │ B/op vs base │
MarshalMessages/1-12 144.00Ki ± 0% 72.00Ki ± 0% -50.00% (p=0.000 n=10)
MarshalMessages/8-12 2760.0Ki ± 0% 520.0Ki ± 0% -81.16% (p=0.000 n=10)
MarshalMessages/64-12 25.719Mi ± 0% 4.008Mi ± 0% -84.42% (p=0.000 n=10)
MarshalMessages/512-12 200.43Mi ± 0% 32.01Mi ± 0% -84.03% (p=0.000 n=10)
geomean 6.648Mi 1.463Mi -78.00%
│ before │ after │
│ allocs/op │ allocs/op vs base │
MarshalMessages/1-12 2.000 ± 0% 1.000 ± 0% -50.00% (p=0.000 n=10)
MarshalMessages/8-12 15.000 ± 0% 1.000 ± 0% -93.33% (p=0.000 n=10)
MarshalMessages/64-12 80.000 ± 0% 1.000 ± 0% -98.75% (p=0.000 n=10)
MarshalMessages/512-12 537.000 ± 0% 1.000 ± 0% -99.81% (p=0.000 n=10)
geomean 33.69 1.000 -97.03%
See mdlayher#254
SuperQ
approved these changes
Jul 19, 2026
SuperQ
left a comment
SuperQ
left a comment
Collaborator
There was a problem hiding this comment.
Question, otherwise LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce allocations in marshalMessages by summing their sizes and then allocating a single buffer to write directly to via a new marshalInto method.
See #254