netlink: test debug output on big-endian systems - #313
Open
dlanov wants to merge 1 commit into
Open
Conversation
nickgarlis
reviewed
Jul 28, 2026
dlanov
force-pushed
the
fix-278-big-endian-tests
branch
from
July 28, 2026 21:03
e7da8dc to
046851b
Compare
Contributor
|
clearly I show this area of different architecture is not my forte :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #278.
TestNlmsgFprintfused captured nftables netlink messages whoseattribute headers were encoded for a little-endian system. Netlink
attribute headers use native byte order, so those fixtures produced
invalid lengths and an out-of-bounds panic when the test ran on s390x.
Build the test messages dynamically with
AttributeEncoderinstead:NFTA_*andNFT_*constants describe the test ruleThis removes the runtime endian conversion and allows the existing
big-endian skip to be removed without changing production behavior.
Add s390x coverage using QEMU user-mode emulation. Rename
TestReceiveItertoTestIntegrationReceiveIterso live-kernel testscan be excluded consistently with
-skip Integration, while the root,nlenc, andnltestpackages run under QEMU.Testing:
go test -run '^TestNlmsgFprintf$' -count=1 -vGOOS=linux GOARCH=s390x CGO_ENABLED=0 go test -exec qemu-s390x-static -tags gofuzz -count=1 -skip Integration ./nlenc ./nltest .go test ./... -count=1go vet ./...git diff --check