Skip to content

Conversation

@natsoni
Copy link
Contributor

@natsoni natsoni commented Jan 30, 2026

Builds on #6247

This PR introduces two main improvements to the Liquid audit implementation:

  • Federation addresses are no longer hardcoded, instead newly used dynafed federation addresses are automatically detected and added to the watchlist (commit e5c3cb7)
  • Peg-in address validation no longer implies a hardcoded timelock of 4032, instead it is derived and verified using tweakfedpegscript RPC (f888c3f)

This is ready for review and testing but I marked as draft because it uses Elements' tweakfedpegscript RPC, which will be fixed in upcoming v23.3.2.

@cla-bot cla-bot bot added the cla-signed label Jan 30, 2026
@natsoni natsoni self-assigned this Jan 30, 2026
@mononaut
Copy link
Contributor

mononaut commented Feb 1, 2026

looks good! it seemed to pick up the latest federation address correctly when I manually removed that from the db and rewound the indexing back to before it was activated.

I did notice that I get a lot of Unable to resolve timelock for peg in address... error logs while indexing earlier blocks - is that because of the tweakfedpegscript thing, or just a skill issue on my part?

@natsoni
Copy link
Contributor Author

natsoni commented Feb 1, 2026

I did notice that I get a lot of Unable to resolve timelock for peg in address... error logs while indexing earlier blocks - is that because of the tweakfedpegscript thing, or just a skill issue on my part?

Hmm this isn't supposed to happen, are you running Elements 23.3.2rc1 ? if not it's probably just the tweakfedpegscript being broken on previous versions

@mononaut
Copy link
Contributor

mononaut commented Feb 1, 2026

I'm on 23.3.0 - will try again with 23.3.2rc1

@psgreco
Copy link
Collaborator

psgreco commented Feb 1, 2026

The tweakfedpegscript rpc was fixed in ElementsProject/elements#1522, which is only included after 23.3.2rc1, if you split this PR in 2, keeping the 4032 hardcoded, you can still use the 23.3.0 or 23.3.1, then after 23.3.2 is released, you can add the second part

@natsoni
Copy link
Contributor Author

natsoni commented Feb 1, 2026

Depending on the planned release date of 23.3.2, we could just wait for that before deploying this PR.

That said, is there a non-negligible chance that another new federation address will be used before 23.3.2 is released, which would make deploying this fix sooner necessary?

@psgreco
Copy link
Collaborator

psgreco commented Feb 1, 2026

No, 23.3.2 will be out it weeks at most. New address with a new timelock is a few months away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants