-
Notifications
You must be signed in to change notification settings - Fork 965
Liquid audit: update federation addresses on-the-fly #6249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
looks good! it seemed to pick up the latest federation address correctly when I manually removed that from the db and rewound the indexing back to before it was activated. I did notice that I get a lot of |
Hmm this isn't supposed to happen, are you running Elements 23.3.2rc1 ? if not it's probably just the |
|
I'm on 23.3.0 - will try again with 23.3.2rc1 |
|
The |
|
Depending on the planned release date of 23.3.2, we could just wait for that before deploying this PR. That said, is there a non-negligible chance that another new federation address will be used before 23.3.2 is released, which would make deploying this fix sooner necessary? |
|
No, |
Builds on #6247
This PR introduces two main improvements to the Liquid audit implementation:
tweakfedpegscriptRPC (f888c3f)This is ready for review and testing but I marked as draft because it uses Elements'
tweakfedpegscriptRPC, which will be fixed in upcoming v23.3.2.