Skip to content

Converter for QuillJS notation#337

Open
Jon-Salmon wants to merge 8 commits into
memspace:masterfrom
Jon-Salmon:stable
Open

Converter for QuillJS notation#337
Jon-Salmon wants to merge 8 commits into
memspace:masterfrom
Jon-Salmon:stable

Conversation

@Jon-Salmon
Copy link
Copy Markdown

Pretty much as stated, a converter for converting between notus and quill formats.

@cgestes
Copy link
Copy Markdown
Collaborator

cgestes commented Jun 8, 2020

It doesnt pass the build. most probably a formatting issue?

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 8, 2020

Codecov Report

❌ Patch coverage is 66.10169% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.55%. Comparing base (0d69499) to head (e7540b0).
⚠️ Report is 132 commits behind head on master.

Files with missing lines Patch % Lines
packages/notus/lib/src/convert/quill.dart 66.10% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
- Coverage   91.89%   90.55%   -1.35%     
==========================================
  Files          11       12       +1     
  Lines        1074     1133      +59     
==========================================
+ Hits          987     1026      +39     
- Misses         87      107      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jon-Salmon
Copy link
Copy Markdown
Author

Jon-Salmon commented Jun 8, 2020

Any idea why this still isn't passing @cgestes ? I've removed the extra import line and added unit tests

@cgestes
Copy link
Copy Markdown
Collaborator

cgestes commented Jun 9, 2020

Formatting?

@Jon-Salmon
Copy link
Copy Markdown
Author

Yup, it was one erroneous line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants