feat: consume packet authenticity settings#40
Conversation
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe PR switches the inherited device-ui dependency to a draft archive and adds a Unity test validating packet authenticity protobuf constants, defaults, and XEdDSA presence. ChangesPacket authenticity integration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
RCGV1
force-pushed
the
codex/packet-auth-policy
branch
from
a91f3fa to
ff6acb1
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
test/test_MeshEnvelope.cpp (1)
87-93: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winExercise the generated default initializer.
_init_zeroonly proves that numeric enum value0maps toBALANCED; it does not verify the schema/generated default initializer if those differ. Usemeshtastic_Config_SecurityConfig_init_defaultwhen available, or confirm that_init_zerois intentionally equivalent.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/test_MeshEnvelope.cpp` around lines 87 - 93, Update the test around meshtastic_Config_SecurityConfig initialization to use meshtastic_Config_SecurityConfig_init_default and assert the expected packet_signature_policy value; if the generated default initializer is intentionally equivalent to _init_zero, explicitly document and test that equivalence instead.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@platformio.ini`:
- Around line 16-17: Replace the temporary RCGV1/device-ui archive URL in the
[device-ui_base] dependency configuration with the merged upstream device-ui
commit or official dependency reference, ensuring all inherited environments use
the upstream version before merging.
---
Nitpick comments:
In `@test/test_MeshEnvelope.cpp`:
- Around line 87-93: Update the test around meshtastic_Config_SecurityConfig
initialization to use meshtastic_Config_SecurityConfig_init_default and assert
the expected packet_signature_policy value; if the generated default initializer
is intentionally equivalent to _init_zero, explicitly document and test that
equivalence instead.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 5b301c00-7a84-4af6-b65d-3984b8609066
⛔ Files ignored due to path filters (4)
lib/mesh/generated/meshtastic/config.pb.cppis excluded by!**/generated/**lib/mesh/generated/meshtastic/config.pb.his excluded by!**/generated/**lib/mesh/generated/meshtastic/mesh.pb.cppis excluded by!**/generated/**lib/mesh/generated/meshtastic/mesh.pb.his excluded by!**/generated/**
📒 Files selected for processing (2)
platformio.initest/test_MeshEnvelope.cpp
RCGV1
force-pushed
the
codex/packet-auth-policy
branch
from
ff6acb1 to
196a279
Compare
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
MUI validation update Added the native MUI input/endpoint configuration used to exercise the packet-auth modal against the simulator, plus the validated screenshot set. Native MUI build passed and the native-mui test suite passed 11/11.
|
1 participant
Summary
Brings standalone-ui onto the shared Packet authenticity configuration implemented by device-ui#341.
SecurityConfig.packet_signature_policyandDeviceMetadata.has_xeddsaThe receive policy is enforced by the connected Meshtastic firmware; standalone-ui only reads and writes the device-owned SecurityConfig.
Validation
git diff --checkpassespio test -e native-mui: 11/11 tests pass, including the packet-authenticity schema contractf23fe8cc0d18af5d1afe6236ce7e24e1d06092cbNo hardware validation has been performed, so this remains a draft.
Draft dependencies
Depends on:
f9c0db84e7fe48986d1ce6df2b8d757f560686a8The temporary contributor-fork device-ui pin must be replaced by the merged upstream commit before this PR leaves draft.
Closes #39
Design: meshtastic/design#121
Summary by CodeRabbit
Tests
Chores