fix: Android LlamaDemo app - remove unnecessary stop code check per model #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
kirklandsign
approved these changes
Feb 4, 2026
There was a problem hiding this comment.
Pull request overview
This PR unifies stop-token handling in the Android LlamaDemo app so that generation stops correctly for all models, including Qwen3. It removes a model-specific condition and always stops the module when the configured stop token is encountered.
Changes:
- In
ChatViewModel.onResult, remove the special-case check forGEMMA_3andLLAVA_1_5and always callmodule?.stop()when the streamed token equals the model’s configured stop token. - Ensure early
returnfromonResultafter stopping to avoid further token processing once the stop token is seen.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...id/LlamaDemo/app/src/main/java/com/example/executorchllamademo/ui/viewmodel/ChatViewModel.kt
Outdated
Show resolved
Hide resolved
…llamademo/ui/viewmodel/ChatViewModel.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue faced - When LlamaDemo app is used with Qwen3, inference would not stop until unless stopped manually
Fix - Removed an unnecessary check that would stop inference only for particular models
Note - Not sure if I am missing something here but as long as stop code is configured in PromptFormat, any model level check should not be required.