Skip to content

Add AArch64 unit test workflow#125

Open
chizkiyahu wants to merge 1 commit into
meta-pytorch:mainfrom
chizkiyahu:linux-aarch64
Open

Add AArch64 unit test workflow#125
chizkiyahu wants to merge 1 commit into
meta-pytorch:mainfrom
chizkiyahu:linux-aarch64

Conversation

@chizkiyahu

Copy link
Copy Markdown

add tests to check the fails in pytorch/executorch#13946

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 4, 2025
@chizkiyahu chizkiyahu force-pushed the linux-aarch64 branch 2 times, most recently from ee7422a to 6708209 Compare September 6, 2025 20:43
@chizkiyahu

Copy link
Copy Markdown
Author

@mergennachin thanks
please approve the workflow

@chizkiyahu

Copy link
Copy Markdown
Author

@mergennachin thanks
please approve the workflow

@larryliu0820 larryliu0820 marked this pull request as ready for review January 27, 2026 23:53
@chizkiyahu

Copy link
Copy Markdown
Author

@larryliu0820

Thanks for approving this.

Do you have an update on when it will be merged?
Should we ping anyone if it needs additional approvals?

@aditew01

aditew01 commented Apr 10, 2026

Copy link
Copy Markdown

@GregoryComer @larryliu0820 @mergennachin can this be merged, i don't see a mergebot to rebase or trigger a merge

@kirklandsign

Copy link
Copy Markdown
Contributor

Hi @chizkiyahu I want to avoid duplicated code. How about

  diff --git a/.github/workflows/pull.yml b/.github/workflows/pull.yml
  index dee3f7e..XXXXXXX 100644
  --- a/.github/workflows/pull.yml
  +++ b/.github/workflows/pull.yml
  @@ -13,17 +13,32 @@ concurrency:

   jobs:
     unittest-linux:
  -    name: unittest-linux
  +    name: unittest-linux (${{ matrix.arch }})
       uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main
       strategy:
         fail-fast: false
  +      matrix:
  +        include:
  +          - arch: x86_64
  +            runner: linux.2xlarge
  +          - arch: aarch64
  +            runner: linux.arm64.2xlarge
       with:
  -      runner: linux.2xlarge
  +      runner: ${{ matrix.runner }}
         submodules: 'true'
         ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
         timeout: 90
         script: |
           set -ex
  +
  +        # Workaround: on aarch64 the sentencepiece CMakeLists links bare
  +        # "atomic", which some toolchains can't resolve. Substitute the
  +        # variable that holds the full libatomic path instead.
  +        # TODO: drop once sentencepiece upstream handles this.
  +        if [ "${{ matrix.arch }}" = "aarch64" ]; then
  +          sed -i 's/list(APPEND SPM_LIBS "atomic")/list(APPEND SPM_LIBS ${ATOMIC_LIB})/' \
  +            third-party/sentencepiece/src/CMakeLists.txt
  +        fi
  +
           cmake -DCMAKE_BUILD_TYPE=Debug test -Bbuild/test
           cmake --build build/test -j9 --config Debug
           pushd build/test && ctest && popd

@chizkiyahu

Copy link
Copy Markdown
Author

@kirklandsign Sorry for the delay. I updated the PR as suggested.

@kirklandsign

Copy link
Copy Markdown
Contributor

Seems we don't have a corresponding docker image. Maybe use raw GH action instead of uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main wrapper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants