Update Node versions #1097
Merged
Update Node versions #1097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Not sure what these test failures are about. Will have to fix them. |
gabegorelick
force-pushed
the
node-versions
branch
from
18421d5 to
182e6d4
Compare
Contributor
Author
|
Tests are fixed. |
gabegorelick
commented
Jun 18, 2025
| var FILES_ENABLED = false; | ||
| try { | ||
| new File([""], ""); // eslint-disable-line no-new | ||
| new FileReaderSync(); // eslint-disable-line no-new |
Contributor
Author
There was a problem hiding this comment.
Node 20 added a File global, but not FileReaderSync or FileReader. We need those or else tests fail when we try to instantiate a FileReaderSync: https://github.com/gabegorelick/PapaParse/blob/be7e72cfd4baf3c25d8631b5823e1b4ae88364be/papaparse.js#L667-L681
Collaborator
There was a problem hiding this comment.
Could you add a comment on the code explaning why FileReader is needed.
Drop versions that are EOL and add newer versions. Node 18 has been end of life since March 27, 2025
Collaborator
|
@gabegorelick Merged it, thanks for taking your time on updating the versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop versions that are EOL and add newer versions.
Node 18 has been end of life since March 27, 2025