Repository navigation
chore: bump react-native-skia to 3.6.3, drop the web matchFamilyStyle patch - #40
Merged
Merged
Conversation
… patch 3.4.4+ ships the web TypefaceFontProvider.matchFamilyStyle fix upstream. Adapts to the 3.6 Canvas API: useCanvasSize() takes no ref and returns onLayout; makeImageSnapshotAsync is gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to VEX-19. Partly addresses VEX-45 (re-measuring on resize).
Summary
react-native-skia3.0.3 → 3.6.3 in the root devDependencies and the example.example/patches/react-native-skia+3.0.3.patchand the example'spostinstall/apply-patchesscripts. The webTypefaceFontProvider.matchFamilyStylefix the patch carried has been in upstream since 3.4.4.>=3.0.0because native is unaffected.Skia 3.6 API changes
useCanvasSize()no longer takes a ref. It returns{ size, onLayout }, andonLayoutgoes on<Canvas>.VexflowCanvasis switched over, so it now re-measures on every layout change, rotation included, instead of measuring once.CanvasRef.makeImageSnapshotAsyncwas removed. The example's worklet diagnostics screen uses the syncmakeImageSnapshot.Verification
yarn typecheck: clean.yarn lint: 0 errors (4 warnings, none in changed files).yarn test: 337 tests pass.yarn prepare: builds.