Skip to content

fix google login missing droidguard#3257

Merged
mar-v-in merged 5 commits intomicrog:masterfrom
DaVinci9196:fix_google_login_missing_droidguard
Feb 6, 2026
Merged

fix google login missing droidguard#3257
mar-v-in merged 5 commits intomicrog:masterfrom
DaVinci9196:fix_google_login_missing_droidguard

Conversation

@DaVinci9196
Copy link
Contributor

1.Avoiding ANR that may occur during login (#3192)
2.fix google login missing droidguard
Problem stack:

org.microg.gms.common.NotOkayException: Error=MissingDroidguard
 at org.microg.gms.common.HttpFormClient.request(HttpFormClient.java:96)
at org.microg.gms.common.HttpFormClient.lambda$requestAsync$0(HttpFormClient.java:210)
at org.microg.gms.common.HttpFormClient$$ExternalSyntheticLambda0.run(Unknown Source:8)

2.fix google login missing droidguard
@ale5000-git
Copy link
Member

I don't know this code too much but does it check if droidguard is enabled in microG settings before using it?

@DaVinci9196
Copy link
Contributor Author

I don't know this code too much but does it check if droidguard is enabled in microG settings before using it?

Currently, based on my testing, this error occurs when installing Microg for the first time and then logging into a Google account.
It's also possible to determine this by checking the enable status of DroidGuard.

@ale5000-git
Copy link
Member

ale5000-git commented Jan 29, 2026

Currently, based on my testing, this error occurs when installing Microg for the first time and then logging into a Google account.
It's also possible to determine this by checking the enable status of DroidGuard.

Perhaps I did not express myself clearly.
My question was: Does microG execute droidguard and include droidguardResults ONLY if safetynet/playIntegrity is enabled in microG settings?

@DaVinci9196
Copy link
Contributor Author

Currently, based on my testing, this error occurs when installing Microg for the first time and then logging into a Google account.
It's also possible to determine this by checking the enable status of DroidGuard.

Perhaps I did not express myself clearly. My question was: Does microG execute droidguard and include droidguardResults ONLY if safetynet/playIntegrity is enabled in microG settings?

ok

@mar-v-in mar-v-in merged commit b6ab193 into microg:master Feb 6, 2026
2 checks passed
@DaVinci9196 DaVinci9196 deleted the fix_google_login_missing_droidguard branch February 9, 2026 06:36
@er13 er13 mentioned this pull request Feb 13, 2026
2 tasks
@er13
Copy link

er13 commented Feb 13, 2026

@DaVinci9196: shouldn't this line be changed in the same way as those from 3a68bc3?

LisoUseInAIKyrios pushed a commit to MorpheApp/MicroG-RE that referenced this pull request Feb 13, 2026
@er13
Copy link

er13 commented Feb 14, 2026

@DaVinci9196

Btw. instead of changing null to "null" shouldn't it be just

--- a/play-services-base/core/src/main/java/org/microg/gms/auth/AuthRequest.java
+++ b/play-services-base/core/src/main/java/org/microg/gms/auth/AuthRequest.java
@@ -68,7 +68,7 @@ public class AuthRequest extends HttpFormClient.Request {
     public boolean getAccountId;
     @RequestContent("ACCESS_TOKEN")
     public boolean isAccessToken;
-    @RequestContent("droidguard_results")
+    @RequestContent("droidguard_results", nullPresent = true)
     public String droidguardResults;
     @RequestContent("has_permission")
     public boolean hasPermission;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants