Removing TOOLS_MODE #84
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the TOOLS_MODE environment variable and related functionality that supported different tool modes (HardCodedTools, MockMCPServer, MCPPlatform). The changes simplify the codebase by standardizing on the MCP Platform approach, removing conditional logic for development/mock scenarios and hardcoded tool implementations.
Key Changes
- Removed the
ToolsModeenum andget_tools_mode()function from the utility module - Simplified
get_mcp_base_url()to always return the MCP platform URL, removing mock server fallback logic - Streamlined
add_tool_servers_to_agent()to always use Bearer token authentication, removing support for mock authorization and hardcoded tools
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| libraries/microsoft-agents-a365-tooling/microsoft_agents_a365/tooling/utils/utility.py | Removed ToolsMode enum, get_tools_mode() function, and conditional logic in get_mcp_base_url() and get_mcp_platform_authentication_scope() |
| libraries/microsoft-agents-a365-tooling/microsoft_agents_a365/tooling/utils/init.py | Removed get_tools_mode from exports list |
| libraries/microsoft-agents-a365-tooling-extensions-semantickernel/microsoft_agents_a365/tooling/extensions/semantickernel/services/mcp_tool_registration_service.py | Removed tools mode checking, mock authorization logic, hardcoded tools support, and simplified authentication to always use Bearer token |
| from microsoft_agents_a365.tooling.services.mcp_tool_server_configuration_service import ( | ||
| McpToolServerConfigurationService, | ||
| ) | ||
| from microsoft_agents_a365.tooling.models.mcp_server_config import MCPServerConfig |
There was a problem hiding this comment.
The copyright header in this file uses "Microsoft. All rights reserved." but should use the standard format "Microsoft Corporation." with "Licensed under the MIT License." as shown in other files in the repository (e.g., init.py). This ensures consistency across the codebase.
Expected format:
# Copyright (c) Microsoft Corporation.
# Licensed under the MIT License.
| name=server.mcp_server_name, | ||
| url=server.mcp_server_unique_name, | ||
| headers=headers or None, | ||
| headers=headers, |
There was a problem hiding this comment.
Do we need to remove this "or None"?
No description provided.