Skip to content

[Shopify] Don't block Shops page when user lacks extension permissions #10034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Onat Buyukakkus (onbuyuka) wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −2
Open

[Shopify] Don't block Shops page when user lacks extension permissions #10034

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/Apps/W1/Shopify/App/src/Base/Codeunits/ShpfyShopMgt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,13 +121,16 @@ codeunit 30211 "Shpfy Shop Mgt."
var
MyNotifications: Record "My Notifications";
EnvironmentInformation: Codeunit "Environment Information";
ExtensionManagement: Codeunit "Extension Management";
BelgianLocalizationNotification: Notification;
IsInstalled: Boolean;
begin
if EnvironmentInformation.GetApplicationFamily() <> BelgianCountryCodeTok then
exit;

if ExtensionManagement.IsInstalledByAppId(GetBelgianLocalizationAppId()) then
if not TryIsBelgianLocalizationInstalled(IsInstalled) then
exit;

if IsInstalled then
exit;

if not MyNotifications.IsEnabled(GetBelgianLocalizationNotificationId()) then
Expand All @@ -141,6 +144,14 @@ codeunit 30211 "Shpfy Shop Mgt."
BelgianLocalizationNotification.Send();
end;

[TryFunction]
local procedure TryIsBelgianLocalizationInstalled(var IsInstalled: Boolean)
var
ExtensionManagement: Codeunit "Extension Management";
begin
IsInstalled := ExtensionManagement.IsInstalledByAppId(GetBelgianLocalizationAppId());
end;

procedure InstallBelgianLocalization(Notification: Notification)
var
ExtensionManagement: Codeunit "Extension Management";
Expand Down
Loading