Skip to content

Promote AA0471, AA0472 and AA0474 to Error in the base ruleset #10209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jesper Schulz-Wedde (JesperSchulz) merged 3 commits into from
Aug 14, 2026
Merged

Promote AA0471, AA0472 and AA0474 to Error in the base ruleset #10209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9458ed4
Remove two redundant overrides from the base ruleset
Aug 12, 2026
944b7ed
Promote five analyzer rules to Error in the base ruleset
Aug 12, 2026
a572e5d
Promote AA0471, AA0472 and AA0474 to Error in the base ruleset
Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Apps/W1/WithholdingTax/app/src/Employee/History/WHTEmplLedgerEntryExt.TableExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ tableextension 6810 "WHT Empl. Ledger Entry Ext" extends "Employee Ledger Entry"
{
Caption = 'Withholding Tax Amount';
AutoFormatType = 1;
AutoFormatExpression = Rec."Currency Code";
Editable = false;
DataClassification = CustomerContent;
ToolTip = 'Specifies the withholding tax amount for the employee ledger entry.';
Expand All @@ -22,6 +23,7 @@ tableextension 6810 "WHT Empl. Ledger Entry Ext" extends "Employee Ledger Entry"
{
Caption = 'Withholding Tax Base Amount';
AutoFormatType = 1;
AutoFormatExpression = Rec."Currency Code";
Editable = false;
DataClassification = CustomerContent;
ToolTip = 'Specifies the withholding tax base amount for the employee ledger entry.';
Expand Down
4 changes: 4 additions & 0 deletions src/Apps/W1/WithholdingTax/app/src/Employee/History/WHTThresholdAccumulator.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,16 @@ table 6794 "WHT Threshold Accumulator"
{
Caption = 'Accumulated Base Amount';
AutoFormatType = 1;
// The accumulator only ever holds local currency amounts.
Comment thread
JesperSchulz marked this conversation as resolved.
AutoFormatExpression = '';
ToolTip = 'Specifies the accumulated base amount for the withholding tax threshold accumulator.';
}
field(9; "Accumulated WHT Amount"; Decimal)
{
Caption = 'Accumulated Withholding Tax Amount';
AutoFormatType = 1;
// The accumulator only ever holds local currency amounts.
AutoFormatExpression = '';
ToolTip = 'Specifies the accumulated withholding tax amount for the withholding tax threshold accumulator.';
}
}
Expand Down
1 change: 1 addition & 0 deletions src/Apps/W1/WithholdingTax/app/src/Purchase/History/WithholdingTaxEntry.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,7 @@ table 6788 "Withholding Tax Entry"
{
Caption = 'Taxable Base Amount';
AutoFormatType = 1;
AutoFormatExpression = Rec."Currency Code";
Editable = false;
}
field(28101; "Pymt. Disc. Diff. Base"; Decimal)
Expand Down
26 changes: 1 addition & 25 deletions src/rulesets/base.ruleset.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,6 @@
"id": "AL0606",
"action": "Warning"
},
{
"id": "AL0640",
"action": "Error"
},
{
"id": "AL0659",
"action": "Warning",
Expand Down Expand Up @@ -96,7 +92,7 @@
{
"id": "AS0112",
"action": "None",
"justification": "The permission set 'Reten. Pol. Setup - BaseApp' should not be included through a permission set extension because it includes permissions for objects defined in another application."
"justification": "Permission set extensions that include permission sets covering objects from another application. Needs a permission set redesign to fix."
},
{
"id": "AS0014",
Expand Down Expand Up @@ -346,26 +342,11 @@
"action": "Warning",
"justification": "Variable with placeholders should have a comment explaining their content."
},
{
"id": "AA0471",
"action": "None",
"justification": "AutoformatType should be defined for decimal fields in Page objects to ensure proper formatting behavior."
},
{
"id": "AA0472",
"action": "None",
"justification": "AutoformatExpression should be defined when AutoformatType is not default to ensure proper formatting behavior."
},
{
"id": "AA0473",
"action": "None",
"justification": "AutoformatType should be defined for decimal fields in Table objects to ensure proper formatting behavior."
},
{
"id": "AA0474",
"action": "None",
"justification": "AutoformatExpression should be defined when AutoformatType is not default to ensure proper formatting behavior."
},
{
"id": "AW0002",
"action": "Warning",
Expand Down Expand Up @@ -430,11 +411,6 @@
"id": "PTE0018",
"action": "Warning"
},
{
"id": "AD0001",
"action": "Error",
"justification": "Analyzer exceptions should be an error as they can prevent other rules from being validated properly."
},
{
"id": "AL0468",
"action": "Warning"
Expand Down
Loading